Cleanup and test PromptInput

NEW
Unassigned

Status

()

P3
normal
3 years ago
2 years ago

People

(Reporter: ahunt, Unassigned)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(firefox47 affected)

Details

(Reporter)

Description

3 years ago
PromptInput and its subclasses store duplicated references to some views, unecessarily force subclasses to down- and subsequently upcast their own views. A further issue is initialisation of their views in getView (without any checks to ensure that Views are not initialised twice).

We should clean these issues up, and also add tests to ensure that we are able to correctly create various types of prompts.

See:
https://bugzilla.mozilla.org/show_bug.cgi?id=1243354#c3
https://bugzilla.mozilla.org/show_bug.cgi?id=1243354#c6
https://bugzilla.mozilla.org/show_bug.cgi?id=1243354#c12

There is a WIP patch (originally part of Bug 1243354) at:
https://bugzilla.mozilla.org/attachment.cgi?id=8713887
(Reporter)

Updated

3 years ago
Assignee: nobody → ahunt
Depends on: 1243354
Priority: -- → P3
(Reporter)

Updated

2 years ago
Assignee: ahunt → nobody
You need to log in before you can comment on or make changes to this bug.