124493 - Purify fails to instrument libnspr

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Brian Ryner (not reading)]

Not sure if this is a bug in purify, or what, but on attempting to run "gmake
pure" in xpfe/bootstrap, it bails out with this error:

Undefined                       first referenced
 symbol                             in file
sigtimedwait                       
/builds/bryner/mozilla/obj-purify/dist/bin/libnspr4.so_pure_p3_c0_106282307_58_32

... and several other symbols.  This can be fixed by linking with -lrt.  We may
want to do this only for the pure: target.

Version info:
CC: Sun WorkShop 6 update 2 C++ 5.3 Patch 111685-04 2001/12/13
purify: Version 2002.05.00 Proto 0010 010628 Solaris 2

Comment 1

[hacker formerly known as [e-mail]]

We already link against -lrt on Solaris >= 5.7.  Is Purify not picking up the
shared library dependency properly?  Would the proper fix be to start including
-lrt in the `nspr-config --libs` output for Solaris?

Comment 2

[Brian Ryner (not reading)]

Right, libnspr4 already links against -lrt.  But for some reason, for purify to
instrument mozilla-bin, we need to also link that against -lrt.

Comment 3

[hacker formerly known as [e-mail]]

Attachment: Add -lrt or -lposix4 to nspr's OS_LIBS as necessary

I decided to fix this one at the source as we'll probably need this fix for
running purify on binaries other than mozilla-bin (like TestGtKEmbed & viewer).
 Values set in nsprpub/configure.in's OS_LIBS should show up in `nspr-config
--libs`.

Comment 4

[Wan-Teh Chang]

Brian,

Could you submit a Purify bug report to Rational Software
or call their technical support about this problem?

Comment 5

[Brian Ryner (not reading)]

Pavlov should do this, he's the one with the Solaris system.

Comment 6

[Brian Ryner (not reading)]

Comment on attachment 70250 [details] [diff] [review]
Add -lrt or -lposix4 to nspr's OS_LIBS as necessary

r=bryner

Comment 7

[Asa Dotzler [:asa]]

a=asa (on behalf of drivers) for checkin to 0.9.9

Comment 8

[hacker formerly known as [e-mail]]

Patch has been checked into the NSPR trunk and the NSPRPUB_PRE_4_2_CLIENT_BRANCH.

Checking in nsprpub/configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.97; previous revision: 1.96
done
Checking in nsprpub/configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.102; previous revision: 1.101
done

Checking in nsprpub/configure;
/cvsroot/mozilla/nsprpub/configure,v  <--  configure
new revision: 1.78.2.18; previous revision: 1.78.2.17
done
Checking in nsprpub/configure.in;
/cvsroot/mozilla/nsprpub/configure.in,v  <--  configure.in
new revision: 1.83.2.18; previous revision: 1.83.2.17
done