1244944 - Import org.json.simple less in services code

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Android Sync, defect)

Description

[Nick Alexander :nalexander [he/him]]

This is one step toward Bug 1204559.  Let's not expose org.json.simple directly in as many ways, and in particular, let's not expose org.json.simple's ParseException directly.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1244944 - Remove old and crufty defer{Get,Put}. r?rnewman

This is safe because the single consumer of `MetaGlobal.fetch` is
`FetchMetaGlobalStage.execute`, which already expects to be called on
a thread and have another thread waiting for the callback.

Review commit: https://reviewboard.mozilla.org/r/33155/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33155/

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1244944 - Remove unused deepCopy method. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/33157/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33157/

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: But 1244944 - Remove untyped EJO.putAll. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/33159/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33159/

Comment 4

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1244944 - Fix test. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/33161/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33161/

Comment 5

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1244944 - Use typed put() variants. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/33163/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33163/

Comment 6

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1244944 - Inline ExtendedJSONObject.parseJSONObject. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/33165/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33165/

Comment 7

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1244944 - Don't throw ParseException from ExtendedJSONObject. r?rnewman

One step further on the path of removing dependence on
org.json.simple: don't expose its exceptions to consumers of EJO.  We
re-purpose the existing UnexpectedJSONException classes to incorporate
what were once ParseException instances.

Review commit: https://reviewboard.mozilla.org/r/33167/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33167/

Comment 8

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1244944 - Don't catch or throw ParseException. r?rnewman

Review commit: https://reviewboard.mozilla.org/r/33169/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33169/

Comment 9

[Nick Alexander :nalexander [he/him]]

Attachment: MozReview Request: Bug 1244944 - Don't stick an org.json.JSONArray into an ExtendedJSONObject. r?rnewman

This works due to string conversions, but it's not elegant.  Let's
just define the API we want, and work to improve the implementation
when we remove org.json.simple entirely.

Review commit: https://reviewboard.mozilla.org/r/33171/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33171/

Comment 10

[Nick Alexander :nalexander [he/him]]

rnewman: the idea with these commits is to clean up some cruft; make the API more explicit, in preparation for handling typed arrays natively; and to reduce surface area of org.simple.json.  One step on the path.

Comment 11

[Nick Alexander :nalexander [he/him]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d7529a9f8fad

Comment 12

[Richard Newman [:rnewman]]

Comment on attachment 8714581 [details]
MozReview Request: Bug 1244944 - Remove old and crufty defer{Get,Put}. r?rnewman

https://reviewboard.mozilla.org/r/33155/#review30955

Comment 13

[Richard Newman [:rnewman]]

Comment on attachment 8714582 [details]
MozReview Request: Bug 1244944 - Remove unused deepCopy method. r?rnewman

https://reviewboard.mozilla.org/r/33157/#review30957

Comment 14

[Richard Newman [:rnewman]]

Comment on attachment 8714583 [details]
MozReview Request: But 1244944 - Remove untyped EJO.putAll. r?rnewman

https://reviewboard.mozilla.org/r/33159/#review30959

Comment 15

[Richard Newman [:rnewman]]

Comment on attachment 8714584 [details]
MozReview Request: Bug 1244944 - Fix test. r?rnewman

https://reviewboard.mozilla.org/r/33161/#review30961

Comment 16

[Richard Newman [:rnewman]]

Comment on attachment 8714585 [details]
MozReview Request: Bug 1244944 - Use typed put() variants. r?rnewman

https://reviewboard.mozilla.org/r/33163/#review30963

Comment 17

[Richard Newman [:rnewman]]

Comment on attachment 8714586 [details]
MozReview Request: Bug 1244944 - Inline ExtendedJSONObject.parseJSONObject. r?rnewman

https://reviewboard.mozilla.org/r/33165/#review30965

Comment 18

[Richard Newman [:rnewman]]

Comment on attachment 8714587 [details]
MozReview Request: Bug 1244944 - Don't throw ParseException from ExtendedJSONObject. r?rnewman

https://reviewboard.mozilla.org/r/33167/#review30967

Comment 19

[Richard Newman [:rnewman]]

Comment on attachment 8714588 [details]
MozReview Request: Bug 1244944 - Don't catch or throw ParseException. r?rnewman

https://reviewboard.mozilla.org/r/33169/#review30969

Comment 20

[Richard Newman [:rnewman]]

Comment on attachment 8714589 [details]
MozReview Request: Bug 1244944 - Don't stick an org.json.JSONArray into an ExtendedJSONObject. r?rnewman

https://reviewboard.mozilla.org/r/33171/#review30971

Comment 21

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/c85b2e048079
https://hg.mozilla.org/integration/fx-team/rev/13f78bc15919
https://hg.mozilla.org/integration/fx-team/rev/e6bd866b6457
https://hg.mozilla.org/integration/fx-team/rev/31dacd6cfb79
https://hg.mozilla.org/integration/fx-team/rev/c1993405f2ca
https://hg.mozilla.org/integration/fx-team/rev/367586933a6a
https://hg.mozilla.org/integration/fx-team/rev/db376a7a4b31
https://hg.mozilla.org/integration/fx-team/rev/1702bbc7c171
https://hg.mozilla.org/integration/fx-team/rev/4fcce95b7993

Comment 22

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c85b2e048079
https://hg.mozilla.org/mozilla-central/rev/13f78bc15919
https://hg.mozilla.org/mozilla-central/rev/e6bd866b6457
https://hg.mozilla.org/mozilla-central/rev/31dacd6cfb79
https://hg.mozilla.org/mozilla-central/rev/c1993405f2ca
https://hg.mozilla.org/mozilla-central/rev/367586933a6a
https://hg.mozilla.org/mozilla-central/rev/db376a7a4b31
https://hg.mozilla.org/mozilla-central/rev/1702bbc7c171
https://hg.mozilla.org/mozilla-central/rev/4fcce95b7993