Closed
Bug 1244966
Opened 8 years ago
Closed 8 years ago
Re-enable testBookmarklets using a simpler test
Categories
(Firefox for Android Graveyard :: Testing, defect)
Firefox for Android Graveyard
Testing
Tracking
(firefox47 fixed)
RESOLVED
FIXED
Firefox 47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: mfinkle, Assigned: mfinkle)
References
Details
Attachments
(1 file)
|
5.68 KB,
patch
|
Margaret
:
review+
|
Details | Diff | Splinter Review |
This version of the code will test two things: 1. Do not allow javascript: URLs manually entered into URL bar 2. Allow loading javascript: URLs from other locations, like bookmarks Try run coming up
Attachment #8714611 -
Flags: review?(michael.l.comella)
|
Assignee | |
Comment 1•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f5e216b5d65
|
|
Assignee | |
Comment 2•8 years ago
|
||
Try build looks good with 8 green rc1 test runs, but triggered a few more just in case.
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8714611 [details] [diff] [review] fix-bookmarklet-test v0.1 Review of attachment 8714611 [details] [diff] [review]: ----------------------------------------------------------------- Drive-by r+, this looks good to me!
Attachment #8714611 -
Flags: review?(michael.l.comella) → review+
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6e1c21facba8
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
|
|
||
Updated•8 years ago
|
Assignee: nobody → mark.finkle
|
||
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•