Closed
Bug 1244982
Opened 8 years ago
Closed 8 years ago
Fix minor double-reporting of memory in prefs code
Categories
(Core :: Preferences: Backend, defect)
Core
Preferences: Backend
Tracking
()
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
1.21 KB,
patch
|
erahm
:
review+
|
Details | Diff | Splinter Review |
DMD pointed out this code in Preferences::SizeOfIncludingThisAndOtherStuff():
n += aMallocSizeOf(gObserverTable);
n += gObserverTable->ShallowSizeOfIncludingThis(aMallocSizeOf);
ShallowSizeOfIncludingThis() itself does |aMallocSizeOf(gObserverTable)|,
because of the "Including".
|
Assignee | |
Comment 1•8 years ago
|
||
Attachment #8714627 -
Flags: review?(erahm)
|
||
Comment 2•8 years ago
|
||
Comment on attachment 8714627 [details] [diff] [review] Fix minor double-reporting of memory in prefs code Review of attachment 8714627 [details] [diff] [review]: ----------------------------------------------------------------- r=me I'm surprised we haven't seen this before...
Attachment #8714627 -
Flags: review?(erahm) → review+
|
|
Assignee | |
Comment 3•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/63c34f2a1a7afc4c69db4277cc953b67be633bda Bug 1244982 - Fix minor double-reporting of memory in prefs code. r=erahm.
|
||
Comment 4•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/63c34f2a1a7a
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•