Closed Bug 1244982 Opened 4 years ago Closed 4 years ago

Fix minor double-reporting of memory in prefs code

Categories

(Core :: Preferences: Backend, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

DMD pointed out this code in Preferences::SizeOfIncludingThisAndOtherStuff():

    n += aMallocSizeOf(gObserverTable);
    n += gObserverTable->ShallowSizeOfIncludingThis(aMallocSizeOf);

ShallowSizeOfIncludingThis() itself does |aMallocSizeOf(gObserverTable)|,
because of the "Including".
Comment on attachment 8714627 [details] [diff] [review]
Fix minor double-reporting of memory in prefs code

Review of attachment 8714627 [details] [diff] [review]:
-----------------------------------------------------------------

r=me I'm surprised we haven't seen this before...
Attachment #8714627 - Flags: review?(erahm) → review+
https://hg.mozilla.org/mozilla-central/rev/63c34f2a1a7a
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.