Closed Bug 1244992 Opened 8 years ago Closed 8 years ago

Avoid double-counting in various refcounted types related to nsCSSValue

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(1 file)

Avoid double-counting in various refcounted types related to nsCSSValue
9.94 KB, patch
heycam
: review+
Details | Diff | Splinter Review 
DMD told me that some nsCSSValueFloatColor values were being double-counted
during memory reporting. Sure enough, it's a refcounted type but this wasn't
being accounted for. And lots of related types have the same problem.
This "only measure if its unshared" approach isn't ideal, but it's used
elsewhere (e.g. nsString) because under-counting is better than over-counting.
Attachment #8714634 - Flags: review?(cam)
Attachment #8714634 - Flags: review?(cam) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/fcf913c1c207f8160e30a27731241d5a3d50d7dd
Bug 1244992 - Avoid double-counting in various refcounted types related to nsCSSValue. r=heycam.
https://hg.mozilla.org/mozilla-central/rev/fcf913c1c207
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: