Crash [@ nsGlobalWindow::HasActiveSpeechSynthesis | nsDocument::CanSavePresentation]

RESOLVED FIXED in Firefox 46

Status

()

--
critical
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: jruderman, Assigned: smaug)

Tracking

(Blocks: 1 bug, {crash, regression, testcase})

Trunk
mozilla47
crash, regression, testcase
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox45 unaffected, firefox46+ fixed, firefox47+ fixed)

Details

Attachments

(4 attachments)

(Reporter)

Description

3 years ago
Created attachment 8714672 [details]
testcase

nsDocument::CanSavePresentation calls nsGlobalWindow::HasActiveSpeechSynthesis on a null |win|. The rest of CanSavePresentation null-checks |win|, so this new code probably should as well.

(Smaug, does it make sense for this convoluted testcase to cause |win| to be null?)
(Reporter)

Comment 1

3 years ago
Created attachment 8714673 [details]
stack
(Assignee)

Comment 2

3 years ago
It is odd to have null win here.
(Assignee)

Comment 3

3 years ago
Created attachment 8714801 [details] [diff] [review]
fo trunk
Assignee: nobody → bugs
Attachment #8714801 - Flags: review?(eitan)
Attachment #8714801 - Flags: review?(eitan) → review+
(Assignee)

Comment 4

3 years ago
Created attachment 8714898 [details] [diff] [review]
for aurora

Approval Request Comment
[Feature/regressing bug #]: Bug 1230533
[User impact if declined]: crashes
[Describe test coverage new/current, TreeHerder]: This is just a null pointer check
[Risks and why]: no risk 
[String/UUID change made/needed]: NA
Attachment #8714898 - Flags: approval-mozilla-aurora?

Comment 6

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a81a510459e5
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Comment on attachment 8714898 [details] [diff] [review]
for aurora

Crash fix for regression from 46, please uplift to aurora.
Attachment #8714898 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox45: --- → unaffected
status-firefox46: --- → affected
tracking-firefox46: --- → +
tracking-firefox47: --- → +

Comment 8

3 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/20b385b8a533
status-firefox46: affected → fixed
You need to log in before you can comment on or make changes to this bug.