Assertion failure: !MustReframeForBeforePseudo() (shouldn't need to reframe ::before as we would have had eRestyle_Subtree and wouldn't get in here), at RestyleManager.cpp:3148

RESOLVED INVALID

Status

()

RESOLVED INVALID
3 years ago
5 months ago

People

(Reporter: cbook, Unassigned)

Tracking

(Blocks: 1 bug, {assertion})

Trunk
assertion
Points:
---

Firefox Tracking Flags

(firefox47 wontfix, firefox50- fix-optional, firefox51- fix-optional, firefox52- wontfix)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
found by bughunter and reproduced on todays m-c tip and windows 7 debug build on https://www.dickeys.com/

steps to reproduce:
-> Load https://www.dickeys.com/ ( you might reload the page a few times)
--> 

Assertion failure: !MustReframeForBeforePseudo() (shouldn't need to reframe ::before as we would have had eRestyle_Subtree and wouldn't get in here), at c:/Users/mozilla/debug-builds/mozilla-central/layout/base/RestyleManager.cpp:3148
#01: mozilla::ElementRestyler::Restyle[xul +0x4531599]
#02: mozilla::ElementRestyler::ComputeStyleChangeFor[xul +0x450eb6a]
#03: mozilla::RestyleManager::ComputeAndProcessStyleChange[xul +0x450c78f]
#04: mozilla::RestyleManager::RestyleElement[xul +0x4532644]
#05: mozilla::RestyleTracker::ProcessOneRestyle[xul +0x45ab1e8]
#06: mozilla::RestyleTracker::DoProcessRestyles[xul +0x4576588]
#07: mozilla::RestyleManager::ProcessRestyles[xul +0x452b49a]
#08: mozilla::RestyleManager::UpdateOnlyAnimationStyles[xul +0x453c71e]
#09: mozilla::RestyleManager::ProcessPendingRestyles[xul +0x452a3a8]
#10: PresShell::FlushPendingNotifications[xul +0x45eec94]
#11: nsRefreshDriver::Tick[xul +0x44ef18c]
#12: nsRefreshDriver::DoTick[xul +0x44e938b]
#13: nsRefreshDriver::DoRefresh[xul +0x44e9240]
#14: nsRefreshDriver::WillRefresh[xul +0x44f092b]
#15: nsRefreshDriver::Tick[xul +0x44eef7f]
#16: nsRefreshDriver::DoTick[xul +0x44e938b]
#17: nsRefreshDriver::DoRefresh[xul +0x44e9240]
#18: nsRefreshDriver::FinishedWaitingForTransaction[xul +0x44e9dbc]
#19: nsRefreshDriver::NotifyTransactionCompleted[xul +0x44eb03c]
#20: mozilla::layers::ClientLayerManager::DidComposite[xul +0x1b07b60]
#21: mozilla::layers::CompositorChild::RecvDidComposite[xul +0x1ba0ba4]
#22: mozilla::layers::PCompositorChild::OnMessageReceived[xul +0x124af7e]
#23: mozilla::ipc::MessageChannel::DispatchAsyncMessage[xul +0xbe8978]
#24: mozilla::ipc::MessageChannel::DispatchMessageW[xul +0xbe9129]
#25: mozilla::ipc::MessageChannel::OnMaybeDequeueOne[xul +0xbef345]
#26: ??$CallMethod@$SVMessageChannel@ipc@mozilla@@P8123@AE_NXZ$$$V@details@@YAXU?$IndexSequence@$S@mozilla@@PAVMessageChannel@ipc@2@P8342@AE_NXZAAV?$Tuple@$$$V@2@@Z[xul +0xbd40b9]
#27: ??$DispatchTupleToMethod@VMessageChannel@ipc@mozilla@@P8123@AE_NXZ$$$V@@YAXPAVMessageChannel@ipc@mozilla@@P8012@AE_NXZAAV?$Tuple@$$$V@2@@Z[xul +0xbd47af]
#28: ?Run@?$RunnableMethod@VMessageChannel@ipc@mozilla@@P8123@AE_NXZV?$Tuple@$$$V@3@@@UAEXXZ[xul +0xbf602a]
#29: mozilla::ipc::MessageChannel::RefCountedTask::Run[xul +0xbf7e3a]
#30: mozilla::ipc::MessageChannel::DequeueTask::Run[xul +0xbf6609]
#31: MessageLoop::RunTask (c:\users\mozilla\debug-builds\mozilla-central\ipc\chromium\src\base\message_loop.cc:365)
#32: MessageLoop::DeferOrRunPendingTask (c:\users\mozilla\debug-builds\mozilla-central\ipc\chromium\src\base\message_loop.cc:375)
#33: MessageLoop::DoWork (c:\users\mozilla\debug-builds\mozilla-central\ipc\chromium\src\base\message_loop.cc:459)
#34: mozilla::ipc::DoWorkRunnable::Run[xul +0xbf66a1]
#35: nsThread::ProcessNextEvent[xul +0x5c2527]
#36: NS_ProcessNextEvent[xul +0x627992]
#37: mozilla::ipc::MessagePump::Run[xul +0xbf6b61]
#38: MessageLoop::RunInternal (c:\users\mozilla\debug-builds\mozilla-central\ipc\chromium\src\base\message_loop.cc:235)
#39: MessageLoop::RunHandler (c:\users\mozilla\debug-builds\mozilla-central\ipc\chromium\src\base\message_loop.cc:228)
#40: MessageLoop::Run (c:\users\mozilla\debug-builds\mozilla-central\ipc\chromium\src\base\message_loop.cc:202)
#41: nsBaseAppShell::Run[xul +0x4102dd0]
#42: nsAppShell::Run (c:\users\mozilla\debug-builds\mozilla-central\widget\windows\nsappshell.cpp:257)
#43: nsAppStartup::Run[xul +0x51b3a8f]
#44: XREMain::XRE_mainRun[xul +0x526506a]
#45: XREMain::XRE_main[xul +0x5261e37]
#46: XRE_main[xul +0x526795a]
#47: do_main (c:\users\mozilla\debug-builds\mozilla-central\browser\app\nsbrowserapp.cpp:212)
#48: NS_internal_main (c:\users\mozilla\debug-builds\mozilla-central\browser\app\nsbrowserapp.cpp:352)
#49: wmain (c:\users\mozilla\debug-builds\mozilla-central\toolkit\xre\nswindowswmain.cpp:131)
#50: __tmainCRTStartup (f:\dd\vctools\crt\crtw32\startup\crt0.c:255)
#51: BaseThreadInitThunk[kernel32 +0x4ee6c]
#52: RtlInitializeExceptionChain[ntdll +0x63ab3]
#53: RtlInitializeExceptionChain[ntdll +0x63a86]
This assertion was added in bug 1180120 by heycam and reviewed by dbaron. Probably they know more about what it means.
Talked with heycam, and he said he'll look into this.
Flags: needinfo?(cam)
(Reporter)

Comment 3

2 years ago
[Tracking Requested - why for this release]:

still reproducible with current builds and nightly -> beta debug on urls like https://offcloud.com/#/cloud
status-firefox50: --- → affected
status-firefox51: --- → affected
status-firefox52: --- → affected
tracking-firefox50: --- → ?
tracking-firefox51: --- → ?
tracking-firefox52: --- → ?
(Reporter)

Comment 4

2 years ago
Created attachment 8800567 [details]
current build stack

stack from a recent build
Not tracking as this is an old bug with no activity.  Xidorn, as heycam seems busy is this something you can look into?
status-firefox47: affected → wontfix
status-firefox50: affected → fix-optional
status-firefox51: affected → fix-optional
tracking-firefox50: ? → -
tracking-firefox51: ? → -
tracking-firefox52: ? → -
Flags: needinfo?(xidorn+moz)
Unfortunately, I'm busy at this moment as well, and I'm not very familiar with our style system especially restyling. Given the project to replace the style system with stylo, I guess this isn't at a high priority.
Component: Layout → CSS Parsing and Computation
Flags: needinfo?(xidorn+moz)
I mean, given that project is on-going, fixing assertions in the current style system may not be a high priority task.

Comment 8

2 years ago
(In reply to Xidorn Quan [:xidorn] (UTC+10) from comment #7)
> I mean, given that project is on-going, fixing assertions in the current
> style system may not be a high priority task.

true. maybe wontfix?
See Also: → bug 1230386
Too late for firefox 52, mass-wontfix.
status-firefox52: affected → wontfix
This code is gone.
Status: NEW → RESOLVED
Last Resolved: 5 months ago
Flags: needinfo?(cam)
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.