1245099 - Address a compilation maybe-uninitialized warning

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Paul Bignier]

Attachment: 0001-Fixed-uninitialized-variable-warning.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20160127060627

Steps to reproduce:

'./mach build' in the gecko repo


Actual results:

Got a [-Wmaybe-uninitialized] warning in xpcom


Expected results:

No warning

Comment 1

[Nathan Froyd [:froydnj]]

Comment on attachment 8714794 [details] [diff] [review]
0001-Fixed-uninitialized-variable-warning.patch

Review of attachment 8714794 [details] [diff] [review]:
-----------------------------------------------------------------

When fixing build warnings, it's helpful to cite the actual build warning in the bug, rather than just saying "there was a warning."  It's clear that you're fixing an uninitialized variable warning related to |value|; it's not clear what's causing the actual warning.

I think the code is smarter than the compiler here, but we might as well initialize it just to make compilation quieter.

Comment 2

[Nathan Froyd [:froydnj]]

Thanks for the patch!  I've marked your patch as needing checkin; somebody will be along to check it in relatively soon.

(Note to said person: this patch is simple enough it doesn't need a try run for checkin-needed.  I've verified that it compiles locally.)

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c409ce7c06a4

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c409ce7c06a4