Address some compilation maybe-uninitialized warnings

ASSIGNED
Assigned to

Status

()

Core
JavaScript Engine
ASSIGNED
2 years ago
2 years ago

People

(Reporter: Paul Bignier, Assigned: Paul Bignier)

Tracking

(Blocks: 1 bug)

47 Branch
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
Created attachment 8714811 [details] [diff] [review]
0001-Fixed-uninitialized-variables-warnings.patch

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20160127060627

Steps to reproduce:

'./mach build' in the gecko repo


Actual results:

Got [-Wmaybe-uninitialized] warnings in js/


Expected results:

No warnings

Note : could not edit the 'Product' field because I didn't find a 'JS' entry
(Assignee)

Updated

2 years ago
Attachment #8714811 - Flags: review?(dolske)
Blocks: 1225428
(Before diving too far into reviewing this, please be aware of the concerns in bug 1225428 comment 18.)
Component: Untriaged → JavaScript Engine
Product: Firefox → Core
Comment on attachment 8714811 [details] [diff] [review]
0001-Fixed-uninitialized-variables-warnings.patch

Needs review / decision on comment 1 from a JS peer. (I moved this to the JS engine component, Firefox::Untriaged won't suggest useful reviewers.)
Attachment #8714811 - Flags: review?(dolske) → review?(luke)
(In reply to Paul Bignier from comment #0)

> Note : could not edit the 'Product' field because I didn't find a 'JS' entry

Oh, I see. Bugzilla's organization can be a little confusing -- most code in Firefox is spread across 3 main "products" -- the rough-and-simplified explanation is that "Firefox" is mainly UI stuff, "Core" is mainly platform stuff (JS, rendering, network, etc), and "Toolkit" are various browser services.

The on "Find product and component:" searchbox on https://bugzilla.mozilla.org/enter_bug.cgi can be useful for helping to find the right spot. http://i.imgur.com/VpJGJQZ.png (Untriaged is fine too, when you're not sure.)

Updated

2 years ago
Attachment #8714811 - Flags: review?(luke) → review+
Assignee: nobody → paul.bignier
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
You need to log in before you can comment on or make changes to this bug.