Closed Bug 1245110 Opened 4 years ago Closed 4 years ago

Remove help about (now removed) "Ask for each cookie" option in preferences dialog

Categories

(SeaMonkey :: Help Documentation, defect)

SeaMonkey 2.41 Branch
defect
Not set

Tracking

(seamonkey2.42 wontfix, seamonkey2.43 fixed, seamonkey2.44 fixed)

RESOLVED FIXED
seamonkey2.44
Tracking Status
seamonkey2.42 --- wontfix
seamonkey2.43 --- fixed
seamonkey2.44 --- fixed

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

References

Details

Attachments

(1 file)

3.45 KB, patch
iann_bugzilla
: review+
tonymec
: feedback+
iann_bugzilla
: approval-comm-aurora+
iann_bugzilla
: approval-comm-beta-
Details | Diff | Splinter Review
+++ This bug was initially created as a clone of Bug #1235199 +++

The backend for this option in the Privacy & Security > Cookies prefpane has been removed from the Core code, so was the radiobutton itself along with the related "except for session cookies" checkbox.

This bug removes respective descriptions from the Help content.
Attached patch Proposed patchSplinter Review
Note that the last hunk refers to a text that has been obsoleted by the introduction of the Data Manager. However, I defer this to bug 599097 to take care of the overall context of that major change, just removing the specific option here.
Assignee: nobody → rsx11m.pub
Status: NEW → ASSIGNED
Attachment #8714824 - Flags: review?(iann_bugzilla)
Comment on attachment 8714824 [details] [diff] [review]
Proposed patch

Adjusting Subject to make it clearer that this is about the help
Attachment #8714824 - Flags: feedback+
Summary: Remove description of "Ask for each cookie" option in preferences dialog now that it has been removed → Remove help about (now removed) "Ask for each cookie" option in preferences dialog
P.S. And thanks rsx11m for cleaning up after me (who forgot about the SeaMonkey Help because I never use it).
(In reply to Tony Mechelynck [:tonymec] from comment #2)
> Adjusting Subject to make it clearer that this is about the help

Thanks. I figured that filing the bug in SeaMonkey's Help component would make its context unambiguous, but it cannot hurt to be more specific.
Attachment #8714824 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Whiteboard: [c-n: comm-central]
Comment on attachment 8714824 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): follow-up to bug 1235199
User impact if declined: Documentation of a no longer existing feature
String changes made by this patch: Help only
Attachment #8714824 - Flags: approval-comm-beta?
Attachment #8714824 - Flags: approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/16f0b7d054b9
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.43
Thanks - trunk is on 2.44 already, though. ;-)
Whiteboard: [c-n: comm-central]
Target Milestone: seamonkey2.43 → seamonkey2.44
Comment on attachment 8714824 [details] [diff] [review]
Proposed patch

too late for c-b, might still be worth a note to l10n
Attachment #8714824 - Flags: approval-comm-beta?
Attachment #8714824 - Flags: approval-comm-beta-
Attachment #8714824 - Flags: approval-comm-aurora?
Attachment #8714824 - Flags: approval-comm-aurora+
Thanks, push for comm-aurora please (merge is scheduled for March 7).
Keywords: checkin-needed
Whiteboard: [c-n: comm-aurora]
Pushed to comm-aurora
Keywords: checkin-needed
Whiteboard: [c-n: comm-aurora]
You need to log in before you can comment on or make changes to this bug.