Closed Bug 1245149 Opened 8 years ago Closed 8 years ago

Inform link clickers on mobile that they should use a desktop

Categories

(Hello (Loop) :: Client, defect, P2)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: RT, Assigned: mancas)

Details

User Story

Acceptance criteria:
- Link clickers on Android, iOS, Windows phone, Blackberry or any other mobile device should be displayed a simple informational message asking them to click the Hello link on a desktop device instead

Attachments

(7 files)

mobile.png
62.70 KB, image/png
Details
[loop] mancas:bug1245149 > mozilla:master
40 bytes, text/x-github-pull-request
mikedeboer
: review+
Details | Review
Mobile version
18.70 KB, image/png
sevaan
: ui-review+
Details
Portrait version
36.91 KB, image/png
sevaan
: ui-review+
Details
Landscape version
36.06 KB, image/png
sevaan
: ui-review+
Details
Android device portrait
73.70 KB, image/png
Details
Android device landscape
80.32 KB, image/png
Details 
      No description provided.
User Story: (updated)
Attached image mobile.png — 

    
    

    
  
Sevaan, does this look fine to you?
Flags: needinfo?(sfranks)

    
  
Rank: 20
Priority: -- → P2

    
    

    
  
Yes
Flags: needinfo?(sfranks)

    
    

    
  
Are we doing just phones or tablets as well? I'm thinking tablet is potentially a slightly more reasonable experience.
Flags: needinfo?(rtestard)

    
  
Assignee: nobody → b.mcb
Status: NEW → ASSIGNED

    
    

    
  
(In reply to Mark Banner (:standard8) from comment #4)
> Are we doing just phones or tablets as well? I'm thinking tablet is
> potentially a slightly more reasonable experience.

Fair point, tablets (Android tablets) seem like they provide an OK experience.
Do we need a resolution to define a device as a tablet?
Flags: needinfo?(rtestard) → needinfo?(sfranks)

    
    

    
  
Comment on attachment 8715265 [details] [review]
[loop] mancas:bug1245149 > mozilla:master

Hi Mike, can you review this patch when you get a chance?

Thank you!

        Attachment #8715265 -
        Flags: review?(mdeboer)

    
    

    
  

      
      
      
      

        Attached image
          
        Mobile version
        — 
      

    


  

        Attachment #8715266 -
        Flags: ui-review?(sfranks)

    
    

    
  

      
      
      
      

        Attached image
          
        Portrait version
        — 
      

    


  

        Attachment #8715267 -
        Flags: ui-review?(sfranks)

    
    

    
  

      
      
      
      

        Attached image
          
        Landscape version
        — 
      

    


  

        Attachment #8715268 -
        Flags: ui-review?(sfranks)
Flags: needinfo?(sfranks)

        Attachment #8715268 -
        Flags: ui-review?(sfranks) → ui-review+

        Attachment #8715267 -
        Flags: ui-review?(sfranks) → ui-review+

        Attachment #8715266 -
        Flags: ui-review?(sfranks) → ui-review+

    
    

    
  
(In reply to Romain Testard [:RT] from comment #5)
> Fair point, tablets (Android tablets) seem like they provide an OK
> experience.
> Do we need a resolution to define a device as a tablet?

I just tried to open a conversation on a tablet with a 1280x960 resolution. The UI looked okay, but I was unable to connect to actually see it in action. Does anyone else have a device we can test this on? I'd be curious about older devices at 1024x768.

    
    

    
  
I put some comments in the PR... could you address them? Thanks!

    
    

    
  
We don't need to land the code before the 1.2 release, but we do need to land the strings before that release.

    
    

    
  
Ok, tomorrow I'll address all the comments. I think the patch will be ready to be landed before 1.2, if not, I'll land just the strings, are you ok with that Ian?
Flags: needinfo?(ianb)

    
    

    
  
Mike I've addressed all the comments. Can you review it and try to land this bug with the strings in the same PR?

Thank you!
Flags: needinfo?(mdeboer)

    
    

    
  
Yes – if the whole patch lands in time for 1.2, great; if not then strings-only.
Flags: needinfo?(ianb)

    
    

    
  
Comment on attachment 8715265 [details] [review]
[loop] mancas:bug1245149 > mozilla:master

LGTM!
Flags: needinfo?(mdeboer)

        Attachment #8715265 -
        Flags: review?(mdeboer) → review+

    
    

    
  
Landed in master: https://github.com/mozilla/loop/commit/530be558181e2c8a3996ba7af49d4cdbe768da92
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: