Closed
Bug 1245153
Opened 5 years ago
Closed 5 years ago
Make remaining utils functionality modules
Categories
(Testing :: Marionette, defect)
Testing
Marionette
Tracking
(firefox47 fixed)
RESOLVED
FIXED
mozilla47
| Tracking | Status | |
|---|---|---|
| firefox47 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
(Keywords: pi-marionette-server)
Attachments
(18 files)
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
automatedtester
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
jmaher
:
review+
|
Details |
|
58 bytes,
text/x-review-board-request
|
pbro
:
review+
|
Details |
The following files are still loaded as subscripts:
loader.loadSubScript("chrome://marionette/content/EventUtils.js", utils);
loader.loadSubScript("chrome://marionette/content/ChromeUtils.js", utils);
loader.loadSubScript("chrome://marionette/content/atoms.js", utils);
loader.loadSubScript("chrome://marionette/content/sendkeys.js", utils);
loader.loadSubScript("chrome://marionette/content/frame-manager.js");
We should turn them into JS modules.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Due to a previous programming error, error.isError only recognised the base Error prototype. It must also test for the other built-in prototypes, such as TypeError et al. Review commit: https://reviewboard.mozilla.org/r/33421/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33421/
Attachment #8715426 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 2•5 years ago
|
||
Generally, Error prototypes that are not based on WebDriverError must be wrapped so that they can be serialised across the AsyncMessageChannel. Review commit: https://reviewboard.mozilla.org/r/33423/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33423/
Attachment #8715427 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 3•5 years ago
|
||
error.wrap acts as a no-op if it is passed a prototype which is already of the WebDriverError prototypal chain. Review commit: https://reviewboard.mozilla.org/r/33425/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33425/
Attachment #8715428 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 4•5 years ago
|
||
testing/marionette/sendkeys.js has been merged into the new testing/marionette/event.js module, together with testing/marionette/EventUtils.js. There is a lot of functionality still left in this module that we can probably remove, as it is not in use by Marionette. Review commit: https://reviewboard.mozilla.org/r/33427/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33427/
Attachment #8715429 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 5•5 years ago
|
||
Through some very clever hacking of the arguments to each of the atoms, we are able to contain this in a JS module: Atoms normally extract their arguments directly from the function scoped `arguments' variable, but by explicitly naming `window' as the last argument in the functions' prototype we are able to set the `window' variable used inside. This is obviously a big hack, but it encapsulates the atoms and we are moving away from atoms in the long term. Review commit: https://reviewboard.mozilla.org/r/33429/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33429/
Attachment #8715430 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 6•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33431/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33431/
Attachment #8715431 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 7•5 years ago
|
||
To simplify the dependency chain and reduce the number of duplicate functions in Marionette, a number of functions have been removed from interactions.js and added to elements.js. This makes them more easily re-usable and works around a circular dependency issue. Review commit: https://reviewboard.mozilla.org/r/33433/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33433/
Attachment #8715432 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 8•5 years ago
|
||
This change removes almost all the remaining uses of loadSubScript and global scope pollution. The only remaining use is for common.js, which is resolved by a later bug for evaluating scripts. Review commit: https://reviewboard.mozilla.org/r/33435/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33435/
Attachment #8715433 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 9•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33437/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33437/
Attachment #8715434 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 10•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33439/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33439/
Attachment #8715435 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 11•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33441/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33441/
Attachment #8715436 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 12•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33443/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33443/
Attachment #8715437 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 13•5 years ago
|
||
This does not appear to be in use. Review commit: https://reviewboard.mozilla.org/r/33445/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33445/
Attachment #8715438 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 14•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33447/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33447/
Attachment #8715439 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 15•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/33449/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33449/
Attachment #8715440 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 16•5 years ago
|
||
There should be no functional changes here. Review commit: https://reviewboard.mozilla.org/r/33451/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33451/
Attachment #8715441 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 17•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/1-2/
|
|
Assignee | |
Comment 18•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/1-2/
|
|
Assignee | |
Comment 19•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/1-2/
|
|
Assignee | |
Comment 20•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/1-2/
|
|
Assignee | |
Comment 21•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/1-2/
|
|
Assignee | |
Comment 22•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/1-2/
|
|
Assignee | |
Comment 23•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/1-2/
|
|
Assignee | |
Comment 24•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/1-2/
|
|
Assignee | |
Comment 25•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/1-2/
|
|
Assignee | |
Comment 26•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/1-2/
|
|
Assignee | |
Comment 27•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/1-2/
|
|
Assignee | |
Comment 28•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/1-2/
|
|
Assignee | |
Comment 29•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/1-2/
|
|
Assignee | |
Comment 30•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/1-2/
|
|
Assignee | |
Comment 31•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/1-2/
|
|
Assignee | |
Comment 32•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/1-2/
|
||
Updated•5 years ago
|
Attachment #8715426 -
Flags: review?(dburns) → review+
|
|
||
Comment 33•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester https://reviewboard.mozilla.org/r/33421/#review30225
|
|
||
Comment 34•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester https://reviewboard.mozilla.org/r/33423/#review30227
Attachment #8715427 -
Flags: review?(dburns) → review+
|
|
||
Comment 35•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester https://reviewboard.mozilla.org/r/33425/#review30229
Attachment #8715428 -
Flags: review?(dburns) → review+
|
|
||
Updated•5 years ago
|
Attachment #8715429 -
Flags: review?(dburns) → review+
|
|
||
Comment 36•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester https://reviewboard.mozilla.org/r/33427/#review30231 ::: testing/marionette/event.js:951 (Diff revision 2) > + debugger; nit: you probably dont want this here.
|
|
||
Comment 37•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester https://reviewboard.mozilla.org/r/33429/#review30235
Attachment #8715430 -
Flags: review?(dburns) → review+
|
|
||
Updated•5 years ago
|
Attachment #8715431 -
Flags: review?(dburns) → review+
|
|
||
Comment 38•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester https://reviewboard.mozilla.org/r/33431/#review30237
|
|
||
Updated•5 years ago
|
Attachment #8715432 -
Flags: review?(dburns) → review+
|
|
||
Comment 39•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester https://reviewboard.mozilla.org/r/33433/#review30243 ::: testing/marionette/elements.js:634 (Diff revision 2) > +} nit: missing `;` ::: testing/marionette/elements.js:659 (Diff revision 2) > + c.x + win.pageXOffset <= vp.right && nit: can you move these to be in line with `vp.left` above
|
|
||
Comment 40•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester https://reviewboard.mozilla.org/r/33435/#review30249
Attachment #8715433 -
Flags: review?(dburns) → review+
|
|
||
Comment 41•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester https://reviewboard.mozilla.org/r/33437/#review30251
Attachment #8715434 -
Flags: review?(dburns) → review+
|
|
||
Comment 42•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester https://reviewboard.mozilla.org/r/33439/#review30253 ::: testing/marionette/listener.js:17 (Diff revision 2) > -Cu.import("chrome://marionette/content/atoms.js"); > +Cu.import("chrome://marionette/content/atom.js"); atom implies that we only have 1 atom in there. Why change the name like this?
Attachment #8715435 -
Flags: review?(dburns)
|
|
||
Comment 43•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester https://reviewboard.mozilla.org/r/33441/#review30255
Attachment #8715436 -
Flags: review?(dburns) → review+
|
|
||
Comment 44•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester https://reviewboard.mozilla.org/r/33441/#review30257 ::: testing/marionette/driver.js:29 (Diff revision 2) > -Cu.import("chrome://marionette/content/elements.js"); > +Cu.import("chrome://marionette/content/element.js"); The object inside is Elements, why the change?
Attachment #8715436 -
Flags: review+
|
|
||
Comment 45•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester https://reviewboard.mozilla.org/r/33443/#review30259 ::: testing/marionette/driver.js:28 (Diff revision 2) > -Cu.import("chrome://marionette/content/interactions.js"); > +Cu.import("chrome://marionette/content/interaction.js"); The object inside is Interactions, why the change?
Attachment #8715437 -
Flags: review?(dburns)
|
|
||
Comment 46•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester https://reviewboard.mozilla.org/r/33445/#review30261
Attachment #8715438 -
Flags: review?(dburns) → review+
|
|
||
Comment 47•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester https://reviewboard.mozilla.org/r/33447/#review30263
Attachment #8715439 -
Flags: review?(dburns) → review+
|
|
||
Comment 48•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester https://reviewboard.mozilla.org/r/33449/#review30265
Attachment #8715440 -
Flags: review?(dburns) → review+
|
|
||
Updated•5 years ago
|
Attachment #8715441 -
Flags: review?(dburns)
|
|
||
Comment 49•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester https://reviewboard.mozilla.org/r/33451/#review30267
|
|
||
Comment 50•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester https://reviewboard.mozilla.org/r/33451/#review30269
Attachment #8715441 -
Flags: review+
|
|
Assignee | |
Comment 51•5 years ago
|
||
https://reviewboard.mozilla.org/r/33441/#review30257 > The object inside is Elements, why the change? There’s no object in this module called `Elements`. The long term plan, however, is to move the various exported symbols onto the `element` object so that we give some impression of module encapsulation: ``` let elementManager = element.Storage(…) element.LocationStrategy.ClassName element.checkVisible(…) element.isXULElement(…) ``` … and so on.
|
|
Assignee | |
Comment 52•5 years ago
|
||
https://reviewboard.mozilla.org/r/33439/#review30253 > atom implies that we only have 1 atom in there. Why change the name like this? It doesn’t really imply this. Just as `element.isXULElement` doesn’t imply there’s only one symbol exposed on `element`, `atom.isElementDisplayed` just means “from the atom module, run this function”. The second point is that all the modules in _testing/marionette_ now follow the same stylistic and linguistic pattern, where singular form is used to describe and bundle together functions that are related to one area. For example `error` exposes multiple different error prototypes, but the module itself exposes functionality as `error.isError` and `error.report`. It’s quite a normal pattern to use singular style to name modules.
|
|
Assignee | |
Comment 53•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/2-3/
|
|
Assignee | |
Comment 54•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/2-3/
|
|
Assignee | |
Comment 55•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/2-3/
|
|
Assignee | |
Comment 56•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/2-3/
|
|
Assignee | |
Comment 57•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/2-3/
|
|
Assignee | |
Comment 58•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/2-3/
|
|
Assignee | |
Comment 59•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/2-3/
|
|
Assignee | |
Comment 60•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/2-3/
|
|
Assignee | |
Comment 61•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/2-3/
|
|
Assignee | |
Comment 62•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/2-3/
Attachment #8715435 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 63•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/2-3/
Attachment #8715436 -
Flags: review?(dburns)
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8715437 -
Flags: review?(dburns)
|
|
Assignee | |
Comment 64•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/2-3/
|
|
Assignee | |
Comment 65•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/2-3/
|
|
Assignee | |
Comment 66•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/2-3/
|
|
Assignee | |
Comment 67•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/2-3/
|
|
Assignee | |
Comment 68•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/2-3/
|
|
Assignee | |
Comment 69•5 years ago
|
||
Manual try run because Autoland-to-try is down: https://treeherder.mozilla.org/#/jobs?repo=try&revision=13f5546bc98a
|
|
||
Comment 70•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester https://reviewboard.mozilla.org/r/33439/#review30313
Attachment #8715435 -
Flags: review?(dburns) → review+
|
|
||
Comment 71•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester https://reviewboard.mozilla.org/r/33443/#review30325
Attachment #8715437 -
Flags: review?(dburns) → review+
|
|
Assignee | |
Comment 72•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/3-4/
|
|
Assignee | |
Comment 73•5 years ago
|
||
Addressed a couple of issues and should get test_switch_remote_frame.py passing: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2f76e0e93605
|
|
||
Comment 74•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester https://reviewboard.mozilla.org/r/33441/#review30369
Attachment #8715436 -
Flags: review?(dburns) → review+
|
||
Comment 75•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/aec0a0166685 https://hg.mozilla.org/integration/mozilla-inbound/rev/1f5e37f8e446 https://hg.mozilla.org/integration/mozilla-inbound/rev/d75ad1397656 https://hg.mozilla.org/integration/mozilla-inbound/rev/4b2a5ee7199e https://hg.mozilla.org/integration/mozilla-inbound/rev/ee7ee24cc65e https://hg.mozilla.org/integration/mozilla-inbound/rev/bd41e4ab829d https://hg.mozilla.org/integration/mozilla-inbound/rev/5da7628c3767 https://hg.mozilla.org/integration/mozilla-inbound/rev/6bb93562a576 https://hg.mozilla.org/integration/mozilla-inbound/rev/55f64197f6b5 https://hg.mozilla.org/integration/mozilla-inbound/rev/3edb67388ad6 https://hg.mozilla.org/integration/mozilla-inbound/rev/80ae953819c8 https://hg.mozilla.org/integration/mozilla-inbound/rev/c1e0abbfa66e https://hg.mozilla.org/integration/mozilla-inbound/rev/22321e6b65e9 https://hg.mozilla.org/integration/mozilla-inbound/rev/1be5f60393a0 https://hg.mozilla.org/integration/mozilla-inbound/rev/4c2b1902d7cd https://hg.mozilla.org/integration/mozilla-inbound/rev/30c8ec933737
|
||
Comment 76•5 years ago
|
||
backed out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=21136158&repo=mozilla-inbound
Flags: needinfo?(ato)
|
|
||
Comment 77•5 years ago
|
||
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/9f7157c44c01
|
|
Assignee | |
Comment 78•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/3-4/
Attachment #8715426 -
Attachment description: MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r?automatedtester → MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester
|
|
Assignee | |
Comment 79•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/3-4/
Attachment #8715427 -
Attachment description: MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r?automatedtester → MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8715428 -
Attachment description: MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r?automatedtester → MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester
|
|
Assignee | |
Comment 80•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/3-4/
|
|
Assignee | |
Comment 81•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/3-4/
Attachment #8715429 -
Attachment description: MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r?automatedtester → MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester
|
|
Assignee | |
Comment 82•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/3-4/
Attachment #8715430 -
Attachment description: MozReview Request: Bug 1245153 - Convert atoms.js to a module; r?automatedtester → MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester
|
|
Assignee | |
Comment 83•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/3-4/
Attachment #8715431 -
Attachment description: MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r?automatedtester → MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8715432 -
Attachment description: MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r?automatedtester → MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester
|
|
Assignee | |
Comment 84•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/3-4/
|
|
Assignee | |
Comment 85•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/3-4/
Attachment #8715433 -
Attachment description: MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r?automatedtester → MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester
|
|
Assignee | |
Comment 86•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/3-4/
Attachment #8715434 -
Attachment description: MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r?automatedtester → MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester
|
|
Assignee | |
Comment 87•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/3-4/
Attachment #8715435 -
Attachment description: MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r?automatedtester → MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester
|
|
Assignee | |
Comment 88•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/3-4/
Attachment #8715436 -
Attachment description: MozReview Request: Bug 1245153 - Rename elements.js to element.js; r?automatedtester → MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester
|
|
Assignee | |
Comment 89•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/3-4/
Attachment #8715437 -
Attachment description: MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r?automatedtester → MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester
|
|
Assignee | |
Comment 90•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/3-4/
Attachment #8715438 -
Attachment description: MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r?automatedtester → MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester
|
|
Assignee | |
Comment 91•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/3-4/
Attachment #8715439 -
Attachment description: MozReview Request: Bug 1245153 - Rename actions.js to action.js; r?automatedtester → MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester
|
|
Assignee | |
Comment 92•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/3-4/
Attachment #8715440 -
Attachment description: MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r?automatedtester → MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester
|
|
Assignee | |
Comment 93•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/4-5/
Attachment #8715441 -
Attachment description: MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r?automatedtester → MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester
|
|
Assignee | |
Comment 94•5 years ago
|
||
testing/marionette/EventUtils.js has been converted to a JS module in testing/marionette/event.js and its API has changed. It was originally a copy of testing/mochitest/tests/SimpleTest/EventUtils.js, and it should be fine to use the original instead. Review commit: https://reviewboard.mozilla.org/r/33781/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33781/
|
|
Assignee | |
Comment 95•5 years ago
|
||
The devtools tests were relying on testing/marionette/EventUtils.js. The latest addition to this patch series changes them to rely on testing/mochitest/tests/SimpleTest/EventUtils.js instead. Try run to confirm that change is fine: https://treeherder.mozilla.org/#/jobs?repo=try&revision=bc8f90fdbba2&group_state=expanded
Flags: needinfo?(ato)
|
|
Assignee | |
Comment 96•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/4-5/
|
|
Assignee | |
Comment 97•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/4-5/
|
|
Assignee | |
Comment 98•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/4-5/
|
|
Assignee | |
Comment 99•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/4-5/
|
|
Assignee | |
Comment 100•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/4-5/
|
|
Assignee | |
Comment 101•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/4-5/
|
|
Assignee | |
Comment 102•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/4-5/
|
|
Assignee | |
Comment 103•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/4-5/
|
|
Assignee | |
Comment 104•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/4-5/
|
|
Assignee | |
Comment 105•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/4-5/
|
|
Assignee | |
Comment 106•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/4-5/
|
|
Assignee | |
Comment 107•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/4-5/
|
|
Assignee | |
Comment 108•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/4-5/
|
|
Assignee | |
Comment 109•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/4-5/
|
|
Assignee | |
Comment 110•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/4-5/
|
|
Assignee | |
Comment 111•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/5-6/
|
|
Assignee | |
Comment 112•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/1-2/
|
|
Assignee | |
Comment 113•5 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=660dcd048efb
|
|
Assignee | |
Comment 114•5 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=761c7c50e81d
|
|
Assignee | |
Comment 115•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/2-3/
|
|
Assignee | |
Comment 116•5 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b6633f71ed64
|
|
Assignee | |
Comment 117•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/5-6/
|
|
Assignee | |
Comment 118•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/5-6/
|
|
Assignee | |
Comment 119•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/5-6/
|
|
Assignee | |
Comment 120•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/5-6/
|
|
Assignee | |
Comment 121•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/5-6/
|
|
Assignee | |
Comment 122•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/5-6/
|
|
Assignee | |
Comment 123•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/5-6/
|
|
Assignee | |
Comment 124•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/5-6/
|
|
Assignee | |
Comment 125•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/5-6/
|
|
Assignee | |
Comment 126•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/5-6/
|
|
Assignee | |
Comment 127•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/5-6/
|
|
Assignee | |
Comment 128•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/5-6/
|
|
Assignee | |
Comment 129•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/5-6/
|
|
Assignee | |
Comment 130•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/5-6/
|
|
Assignee | |
Comment 131•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/5-6/
|
|
Assignee | |
Comment 132•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/6-7/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Attachment description: MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset → MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r?pbrosset
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 133•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/3-4/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 134•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/6-7/
|
|
Assignee | |
Comment 135•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/6-7/
|
|
Assignee | |
Comment 136•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/6-7/
|
|
Assignee | |
Comment 137•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/6-7/
|
|
Assignee | |
Comment 138•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/6-7/
|
|
Assignee | |
Comment 139•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/6-7/
|
|
Assignee | |
Comment 140•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/6-7/
|
|
Assignee | |
Comment 141•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/6-7/
|
|
Assignee | |
Comment 142•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/6-7/
|
|
Assignee | |
Comment 143•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/6-7/
|
|
Assignee | |
Comment 144•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/6-7/
|
|
Assignee | |
Comment 145•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/6-7/
|
|
Assignee | |
Comment 146•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/6-7/
|
|
Assignee | |
Comment 147•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/6-7/
|
|
Assignee | |
Comment 148•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/6-7/
|
|
Assignee | |
Comment 149•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/7-8/
|
|
Assignee | |
Comment 150•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/4-5/
|
|
Assignee | |
Comment 151•5 years ago
|
||
EventUtils.js previously allowed you to override the Window object reference through passing it as an optional argument to its functions. This change fixes certain uses of implicit globals that reside on Window. Review commit: https://reviewboard.mozilla.org/r/33991/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33991/
|
|
Assignee | |
Comment 152•5 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=48a0b894185b
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716921 -
Flags: review?(jmaher)
|
||
Comment 153•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher https://reviewboard.mozilla.org/r/33781/#review30603 This seems like a lot of duplicated lines of code to make a simple helper script work. Other tests in the tree that use chrome://mochikit/content/tests/SimpleTest/EventUtils.js seem to do the same, and if try is happy, I'm happy. We should remove some of the instances of devtools tests that need this and make them use BrowserTestUtils instead. I'll file another bug for us to do that.
Attachment #8716299 -
Flags: review?(pbrosset) → review+
|
|
||
Comment 154•5 years ago
|
||
https://reviewboard.mozilla.org/r/33781/#review30605 ::: devtools/client/shared/frame-script-utils.js:24 (Diff revision 5) > +subScriptLoader.loadSubScript("chrome://mochikit/content/tests/SimpleTest/EventUtils.js", EventUtils); I just realized that in this frame-script, the only message listener that uses EventUtils is Test:SynthesizeKey, and it turns out that in devtools, no existing test uses this message anymore. So instead, you could just delete the EventUtils import and delete the Test:SynthesizeKey message listener.
|
|
Assignee | |
Comment 155•5 years ago
|
||
https://reviewboard.mozilla.org/r/33781/#review30603 I had two options in this case: Either copy the old EventUtils.js from Marionette into the devtools tree, or try to fix the new EventUtils.js in mochitest to be compatible with the way the devtools tests that had relied on Marionette’s version uses it. I chose the latter to avoid any more duplication than strictly necessary. I obviously agree entirely with replacing EventUtils.js altogether with something more self-contained and reusable.
|
|
Assignee | |
Comment 156•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/5-6/
Attachment #8716299 -
Attachment description: MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r?pbrosset → MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r?jmaher
Attachment #8716299 -
Flags: review?(jmaher)
|
|
Assignee | |
Comment 157•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/1-2/
Attachment #8716921 -
Attachment description: MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r?jmaher → MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r?pbrosset
Attachment #8716921 -
Flags: review?(jmaher) → review?(pbrosset)
|
|
Assignee | |
Comment 158•5 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=de5761a35fa8
|
|
||
Comment 159•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset https://reviewboard.mozilla.org/r/33991/#review30619 Thanks for the cleanup.
Attachment #8716921 -
Flags: review?(pbrosset) → review+
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review+
|
|
Assignee | |
Comment 160•5 years ago
|
||
This is a digression. (In reply to Andreas Tolfsen (:ato) from comment #155) > I obviously agree entirely with replacing EventUtils.js altogether with > something more self-contained and reusable. In fact, it’s quite possible that ‘this something’ should live in Marionette and be a normal JS module that is _wrapped_ by mochitest as a subscript, so that the back-end could be re-used by everyone; regardless of whether you want the functionality in the same namespace or as a module.
|
||
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(jmaher) → review+
|
|
||
Comment 161•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher https://reviewboard.mozilla.org/r/33781/#review30763 thanks for writing this1
|
|
Assignee | |
Comment 162•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/7-8/
|
|
Assignee | |
Comment 163•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/7-8/
|
|
Assignee | |
Comment 164•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/7-8/
|
|
Assignee | |
Comment 165•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/7-8/
|
|
Assignee | |
Comment 166•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/7-8/
|
|
Assignee | |
Comment 167•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/7-8/
|
|
Assignee | |
Comment 168•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/7-8/
|
|
Assignee | |
Comment 169•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/7-8/
|
|
Assignee | |
Comment 170•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/7-8/
|
|
Assignee | |
Comment 171•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/7-8/
|
|
Assignee | |
Comment 172•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/7-8/
|
|
Assignee | |
Comment 173•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/7-8/
|
|
Assignee | |
Comment 174•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/7-8/
|
|
Assignee | |
Comment 175•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/7-8/
|
|
Assignee | |
Comment 176•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/7-8/
|
|
Assignee | |
Comment 177•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/8-9/
|
|
Assignee | |
Comment 178•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/6-7/
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 179•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/2-3/
|
|
||
Comment 180•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/36526a2e8b00 https://hg.mozilla.org/integration/mozilla-inbound/rev/dc6460e0f336 https://hg.mozilla.org/integration/mozilla-inbound/rev/eff85dc0eaa9 https://hg.mozilla.org/integration/mozilla-inbound/rev/048d70070751 https://hg.mozilla.org/integration/mozilla-inbound/rev/e41a5b41859a https://hg.mozilla.org/integration/mozilla-inbound/rev/6ebd9fde50c0 https://hg.mozilla.org/integration/mozilla-inbound/rev/68a6dda373d2 https://hg.mozilla.org/integration/mozilla-inbound/rev/ad5bf32d8fef https://hg.mozilla.org/integration/mozilla-inbound/rev/b3be2d2f3ac1 https://hg.mozilla.org/integration/mozilla-inbound/rev/5fe42d498a2a https://hg.mozilla.org/integration/mozilla-inbound/rev/63a56310a1b5 https://hg.mozilla.org/integration/mozilla-inbound/rev/6da8099573f3 https://hg.mozilla.org/integration/mozilla-inbound/rev/3b9e9a027fa7 https://hg.mozilla.org/integration/mozilla-inbound/rev/9f3f1c358e47 https://hg.mozilla.org/integration/mozilla-inbound/rev/f79252e92acc https://hg.mozilla.org/integration/mozilla-inbound/rev/c29a348930a4 https://hg.mozilla.org/integration/mozilla-inbound/rev/98b6d0c053c0 https://hg.mozilla.org/integration/mozilla-inbound/rev/18d54b8d4ae8
|
|
||
Comment 181•5 years ago
|
||
backed out for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=21529039&repo=mozilla-inbound
Flags: needinfo?(ato)
|
|
Assignee | |
Comment 182•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/8-9/
|
|
Assignee | |
Comment 183•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/8-9/
|
|
Assignee | |
Comment 184•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/8-9/
|
|
Assignee | |
Comment 185•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/8-9/
|
|
Assignee | |
Comment 186•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/8-9/
|
|
Assignee | |
Comment 187•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/8-9/
|
|
Assignee | |
Comment 188•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/8-9/
|
|
Assignee | |
Comment 189•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/8-9/
|
|
Assignee | |
Comment 190•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/8-9/
|
|
Assignee | |
Comment 191•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/8-9/
|
|
Assignee | |
Comment 192•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/8-9/
|
|
Assignee | |
Comment 193•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/8-9/
|
|
Assignee | |
Comment 194•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/8-9/
|
|
Assignee | |
Comment 195•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/8-9/
|
|
Assignee | |
Comment 196•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/8-9/
|
|
Assignee | |
Comment 197•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/9-10/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Attachment description: MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r?jmaher → MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher
|
|
Assignee | |
Comment 198•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/7-8/
|
|
Assignee | |
Comment 199•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/3-4/
Attachment #8716921 -
Attachment description: MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r?pbrosset → MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset
|
|
||
Comment 200•5 years ago
|
||
Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/2baea2550106
|
|
Assignee | |
Comment 201•5 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=0706694d6d67
Flags: needinfo?(ato)
|
|
||
Comment 202•5 years ago
|
||
(In reply to Andreas Tolfsen ‹:ato› from comment #178) > Comment on attachment 8716299 [details] > MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for > sub-calls consistently; r=jmaher > > Review request updated; see interdiff: > https://reviewboard.mozilla.org/r/33781/diff/6-7/ Did you intend to ask me for review on this patch? It's been reviewed already, and you've landed the changes since then, so I guess this was a mistake?
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 203•5 years ago
|
||
(In reply to Patrick Brosset [:pbrosset] [:pbro] from comment #202) > Did you intend to ask me for review on this patch? It's been reviewed > already, and you've landed the changes since then, so I guess this was a > mistake? Oh sorry, no I did not. This is a bug in MozReview that I’ve reported. Again I’m terribly sorry about the noise.
|
|
Assignee | |
Comment 204•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/9-10/
|
|
Assignee | |
Comment 205•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/9-10/
|
|
Assignee | |
Comment 206•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/9-10/
|
|
Assignee | |
Comment 207•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/9-10/
|
|
Assignee | |
Comment 208•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/9-10/
|
|
Assignee | |
Comment 209•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/9-10/
|
|
Assignee | |
Comment 210•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/9-10/
|
|
Assignee | |
Comment 211•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/9-10/
|
|
Assignee | |
Comment 212•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/9-10/
|
|
Assignee | |
Comment 213•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/9-10/
|
|
Assignee | |
Comment 214•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/9-10/
|
|
Assignee | |
Comment 215•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/9-10/
|
|
Assignee | |
Comment 216•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/9-10/
|
|
Assignee | |
Comment 217•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/9-10/
|
|
Assignee | |
Comment 218•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/9-10/
|
|
Assignee | |
Comment 219•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/10-11/
|
|
Assignee | |
Comment 220•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/8-9/
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 221•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/4-5/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 222•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/9-10/
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 223•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/5-6/
|
|
||
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 224•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/10-11/
|
|
Assignee | |
Comment 225•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/10-11/
|
|
Assignee | |
Comment 226•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/10-11/
|
|
Assignee | |
Comment 227•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/10-11/
|
|
Assignee | |
Comment 228•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/10-11/
|
|
Assignee | |
Comment 229•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/10-11/
|
|
Assignee | |
Comment 230•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/10-11/
|
|
Assignee | |
Comment 231•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/10-11/
|
|
Assignee | |
Comment 232•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/10-11/
|
|
Assignee | |
Comment 233•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/10-11/
|
|
Assignee | |
Comment 234•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/10-11/
|
|
Assignee | |
Comment 235•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/10-11/
|
|
Assignee | |
Comment 236•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/10-11/
|
|
Assignee | |
Comment 237•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/10-11/
|
|
Assignee | |
Comment 238•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/10-11/
|
|
Assignee | |
Comment 239•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/11-12/
|
|
Assignee | |
Comment 240•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/10-11/
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 241•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/6-7/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 242•5 years ago
|
||
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9a8ccee0a0bc&group_state=expanded
|
|
Assignee | |
Comment 243•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/11-12/
|
|
Assignee | |
Comment 244•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/11-12/
|
|
Assignee | |
Comment 245•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/11-12/
|
|
Assignee | |
Comment 246•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/11-12/
|
|
Assignee | |
Comment 247•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/11-12/
|
|
Assignee | |
Comment 248•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/11-12/
|
|
Assignee | |
Comment 249•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/11-12/
|
|
Assignee | |
Comment 250•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/11-12/
|
|
Assignee | |
Comment 251•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/11-12/
|
|
Assignee | |
Comment 252•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/11-12/
|
|
Assignee | |
Comment 253•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/11-12/
|
|
Assignee | |
Comment 254•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/11-12/
|
|
Assignee | |
Comment 255•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/11-12/
|
|
Assignee | |
Comment 256•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/11-12/
|
|
Assignee | |
Comment 257•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/11-12/
|
|
Assignee | |
Comment 258•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/12-13/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 259•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/11-12/
|
|
Assignee | |
Comment 260•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/7-8/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 261•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/12-13/
|
|
Assignee | |
Comment 262•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/8-9/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 263•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/13-14/
|
|
Assignee | |
Comment 264•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/9-10/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 265•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/14-15/
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 266•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/10-11/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 267•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/12-13/
|
|
Assignee | |
Comment 268•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/12-13/
|
|
Assignee | |
Comment 269•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/12-13/
|
|
Assignee | |
Comment 270•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/12-13/
|
|
Assignee | |
Comment 271•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/12-13/
|
|
Assignee | |
Comment 272•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/12-13/
|
|
Assignee | |
Comment 273•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/12-13/
|
|
Assignee | |
Comment 274•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/12-13/
|
|
Assignee | |
Comment 275•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/12-13/
|
|
Assignee | |
Comment 276•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/12-13/
|
|
Assignee | |
Comment 277•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/12-13/
|
|
Assignee | |
Comment 278•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/12-13/
|
|
Assignee | |
Comment 279•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/12-13/
|
|
Assignee | |
Comment 280•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/12-13/
|
|
Assignee | |
Comment 281•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/12-13/
|
|
Assignee | |
Comment 282•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/13-14/
|
|
Assignee | |
Comment 283•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/15-16/
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 284•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/11-12/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 285•5 years ago
|
||
Comment on attachment 8715426 [details] MozReview Request: Bug 1245153 - error.isError must recognise built-in Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33421/diff/13-14/
|
|
Assignee | |
Comment 286•5 years ago
|
||
Comment on attachment 8715427 [details] MozReview Request: Bug 1245153 - Add error.wrap to wrap Error prototypes; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33423/diff/13-14/
|
|
Assignee | |
Comment 287•5 years ago
|
||
Comment on attachment 8715428 [details] MozReview Request: Bug 1245153 - Wrap errors before they are passed through the IPC channel; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33425/diff/13-14/
|
|
Assignee | |
Comment 288•5 years ago
|
||
Comment on attachment 8715429 [details] MozReview Request: Bug 1245153 - Convert EventUtils.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33427/diff/13-14/
|
|
Assignee | |
Comment 289•5 years ago
|
||
Comment on attachment 8715430 [details] MozReview Request: Bug 1245153 - Convert atoms.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33429/diff/13-14/
|
|
Assignee | |
Comment 290•5 years ago
|
||
Comment on attachment 8715431 [details] MozReview Request: Bug 1245153 - Convert frame-manager.js to a module; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33431/diff/13-14/
|
|
Assignee | |
Comment 291•5 years ago
|
||
Comment on attachment 8715432 [details] MozReview Request: Bug 1245153 - Convert interactions.js and elements.js to modules; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33433/diff/13-14/
|
|
Assignee | |
Comment 292•5 years ago
|
||
Comment on attachment 8715433 [details] MozReview Request: Bug 1245153 - Employ new modules throughout Marionette; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33435/diff/13-14/
|
|
Assignee | |
Comment 293•5 years ago
|
||
Comment on attachment 8715434 [details] MozReview Request: Bug 1245153 - Add event.js module and remove EventUtils.js and sendkeys.js from manifest; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33437/diff/13-14/
|
|
Assignee | |
Comment 294•5 years ago
|
||
Comment on attachment 8715435 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/atoms; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33439/diff/13-14/
|
|
Assignee | |
Comment 295•5 years ago
|
||
Comment on attachment 8715436 [details] MozReview Request: Bug 1245153 - Rename elements.js to element.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33441/diff/13-14/
|
|
Assignee | |
Comment 296•5 years ago
|
||
Comment on attachment 8715437 [details] MozReview Request: Bug 1245153 - Rename interactions.js to interaction.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33443/diff/13-14/
|
|
Assignee | |
Comment 297•5 years ago
|
||
Comment on attachment 8715438 [details] MozReview Request: Bug 1245153 - Remove testing/marionette/ChromeUtils.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33445/diff/13-14/
|
|
Assignee | |
Comment 298•5 years ago
|
||
Comment on attachment 8715439 [details] MozReview Request: Bug 1245153 - Rename actions.js to action.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33447/diff/13-14/
|
|
Assignee | |
Comment 299•5 years ago
|
||
Comment on attachment 8715440 [details] MozReview Request: Bug 1245153 - Rename frame-manager.js to frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33449/diff/13-14/
|
|
Assignee | |
Comment 300•5 years ago
|
||
Comment on attachment 8715441 [details] MozReview Request: Bug 1245153 - Lint testing/marionette/frame.js; r=automatedtester Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33451/diff/14-15/
|
|
Assignee | |
Comment 301•5 years ago
|
||
Comment on attachment 8716299 [details] MozReview Request: Bug 1245153 - Make EventUtils.js use aWindow argument for sub-calls consistently; r=jmaher Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33781/diff/16-17/
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
Assignee | |
Comment 302•5 years ago
|
||
Comment on attachment 8716921 [details] MozReview Request: Bug 1245153 - Use EventUtils.js from mochikit; r=pbrosset Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33991/diff/12-13/
|
|
Assignee | |
Updated•5 years ago
|
Attachment #8716299 -
Flags: review?(pbrosset)
|
|
||
Comment 303•5 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/eab5e0afc99a https://hg.mozilla.org/integration/mozilla-inbound/rev/92bbb5f047b3 https://hg.mozilla.org/integration/mozilla-inbound/rev/a95822fe264c https://hg.mozilla.org/integration/mozilla-inbound/rev/fb2e6ed35dec https://hg.mozilla.org/integration/mozilla-inbound/rev/e853ad1a013c https://hg.mozilla.org/integration/mozilla-inbound/rev/a0ff8dcb85f5 https://hg.mozilla.org/integration/mozilla-inbound/rev/1e4fe33c534a https://hg.mozilla.org/integration/mozilla-inbound/rev/adc7a3abfb6d https://hg.mozilla.org/integration/mozilla-inbound/rev/24c62f919a71 https://hg.mozilla.org/integration/mozilla-inbound/rev/034505ccb2cc https://hg.mozilla.org/integration/mozilla-inbound/rev/4ae6cfe28a2c https://hg.mozilla.org/integration/mozilla-inbound/rev/d71447232fbe https://hg.mozilla.org/integration/mozilla-inbound/rev/2848c684e836 https://hg.mozilla.org/integration/mozilla-inbound/rev/95ee48afecba https://hg.mozilla.org/integration/mozilla-inbound/rev/2b54e60dddcd https://hg.mozilla.org/integration/mozilla-inbound/rev/234abb0664d4 https://hg.mozilla.org/integration/mozilla-inbound/rev/489672415fb3 https://hg.mozilla.org/integration/mozilla-inbound/rev/32dc11f5f92e
|
||
Comment 304•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/eab5e0afc99a https://hg.mozilla.org/mozilla-central/rev/92bbb5f047b3 https://hg.mozilla.org/mozilla-central/rev/a95822fe264c https://hg.mozilla.org/mozilla-central/rev/fb2e6ed35dec https://hg.mozilla.org/mozilla-central/rev/e853ad1a013c https://hg.mozilla.org/mozilla-central/rev/a0ff8dcb85f5 https://hg.mozilla.org/mozilla-central/rev/1e4fe33c534a https://hg.mozilla.org/mozilla-central/rev/adc7a3abfb6d https://hg.mozilla.org/mozilla-central/rev/24c62f919a71 https://hg.mozilla.org/mozilla-central/rev/034505ccb2cc https://hg.mozilla.org/mozilla-central/rev/4ae6cfe28a2c https://hg.mozilla.org/mozilla-central/rev/d71447232fbe https://hg.mozilla.org/mozilla-central/rev/2848c684e836 https://hg.mozilla.org/mozilla-central/rev/95ee48afecba https://hg.mozilla.org/mozilla-central/rev/2b54e60dddcd https://hg.mozilla.org/mozilla-central/rev/234abb0664d4 https://hg.mozilla.org/mozilla-central/rev/489672415fb3 https://hg.mozilla.org/mozilla-central/rev/32dc11f5f92e
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
|
|
Assignee | |
Comment 305•5 years ago
|
||
https://reviewboard.mozilla.org/r/33421/#review65656
You need to log in
before you can comment on or make changes to this bug.
Description
•