Closed Bug 1245212 Opened 4 years ago Closed 4 years ago
.sessionstore .debug .no _auto _updates doesn't properly cancel active timers
MozReview Request: Bug 1245212 - Properly cancel SessionStore:update message timers if timeoutDisabled is set to true. r?billm
58 bytes, text/x-review-board-request
Pretty sure this is causing bug 1231422. The sign was wrong here, so we were only canceling the active timer if we were _re-enabling_ the MessageQueue timer. :/ Luckily this is only testing code. This try push seems to indicate that this will fix the intermittent from bug 1231422: https://treeherder.mozilla.org/#/jobs?repo=try&revision=03c1b1945fdb
Review commit: https://reviewboard.mozilla.org/r/33273/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/33273/
Attachment #8714943 - Flags: review?(wmccloskey)
Comment on attachment 8714943 [details] MozReview Request: Bug 1245212 - Properly cancel SessionStore:update message timers if timeoutDisabled is set to true. r?billm https://reviewboard.mozilla.org/r/33273/#review30815 Very sorry this took so long! Somehow I missed it among a bunch of other reviews.
Attachment #8714943 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/integration/fx-team/rev/dc2c6c1a4fe3ed7413ce361e1dcf2c556d1384b0 Bug 1245212 - Properly cancel SessionStore:update message timers if timeoutDisabled is set to true. r=billm
ni'ing myself to get this uplifted everywhere to get rid of the orange in as many places as possible.
Hey lizzard, I'm wondering if you can help me: this small patch fixes an intermittent orange, and it's been asked that I uplift it where possible. RyanVM also said that according to tree rules, as this patch only effects tests, I can land with a=test-only. Since the fix is already on mozilla-central and mozilla-aurora, I only have to worry about beta and esr45, right? I feel confident landing the patch on beta, but is there anything special I need to do about the esr branch?
Flags: needinfo?(mconley) → needinfo?(lhenry)
Yes, you can land it directly on mozilla-beta. I think it is best to double check with Sylvestre about esr at the moment because we are in mid-process for a dot release. (But I predict it is OK to do this) And, yay, down with orange!
Flags: needinfo?(lhenry) → needinfo?(sledru)
No worries, go ahead for esr
Landed on Beta and ESR 45. Thanks, all! https://hg.mozilla.org/releases/mozilla-beta/rev/0eb641ceffa2 https://hg.mozilla.org/releases/mozilla-esr45/rev/9b294782389a
[bugday-20160323] Status: RESOLVED,FIXED -> UNVERIFIED Comments: STR: Not clear. Developer specific testing Component: Name Firefox Version 46.0b9 Build ID 20160322075646 Update Channel beta User Agent Mozilla/5.0 (Windows NT 6.1; WOW64; rv:46.0) Gecko/20100101 Firefox/46.0 OS Windows 7 SP1 x86_64 Expected Results: Developer specific testing Actual Results: As expected
You need to log in before you can comment on or make changes to this bug.