If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Typo in layout_errors.properties since bug 1229052

RESOLVED FIXED in Firefox 47

Status

()

Core
Panning and Zooming
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: Julien G, Assigned: kats)

Tracking

Trunk
mozilla47
Points:
---

Firefox Tracking Flags

(firefox46 wontfix, firefox47 fixed)

Details

(Whiteboard: [mozfr-community])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
Created attachment 8714967 [details]
Screenshot of console warning with typo

There is a minor typo in the new strings added with bug 1229052 on dom/locales/en-US/chrome/layout/layout_errors.properties

one can read " …see https://developers.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects…" when the canonical domain name for MDN is developer.mozilla.org (the "typo-less" URL would be https://developer.mozilla.org/docs/Mozilla/Performance/ScrollLinkedEffects)
(Reporter)

Updated

2 years ago
Whiteboard: [mozfr-community]
Whoops, sorry. I can fix it. Do you know if I should update the entity name as well? According to [1] I only need to do that if the meaning has changed. But on the other hand the change will need to propagated to all the languages, right?

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Updating_Entity_Names
Assignee: nobody → bugmail.mozilla
Blocks: 1229052
status-firefox46: --- → affected
status-firefox47: --- → affected
OS: Unspecified → All
Hardware: Unspecified → All
Version: unspecified → Trunk
(Reporter)

Comment 2

2 years ago
Well, the meaning of the string definitely didn't change and I assume that l10n will detect a change happened (e.g. Pontoon will display the string as "fuzzy").

n.i.-ing Théo to check this last point. :s
Flags: needinfo?(theo)
Yup, please update the string ID as usual, most locales won't catch the change otherwise (there is no "fuzzy" state as tools differ from one team to another).

Thanks
Flags: needinfo?(theo)
Also, since 46 is string frozen, we won't fix it there
status-firefox46: affected → wontfix
Created attachment 8715288 [details]
MozReview Request: Bug 1245245 - Fix typo in error string URL. r?botond

Review commit: https://reviewboard.mozilla.org/r/33373/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33373/
Attachment #8715288 - Flags: review?(botond)

Updated

2 years ago
Attachment #8715288 - Flags: review?(botond) → review+
Comment on attachment 8715288 [details]
MozReview Request: Bug 1245245 - Fix typo in error string URL. r?botond

https://reviewboard.mozilla.org/r/33373/#review30139

Comment 7

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c4d77b43082

Comment 8

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9c4d77b43082
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.