Closed Bug 1245246 Opened 4 years ago Closed 4 years ago
crash in ns
Print Engine::Fire Printing Error Event
This bug was filed from the Socorro interface and is report bp-67527034-9eee-429f-8e83-7e9932160202. ============================================================= Looks like the mPrintEngine might be getting cleaned up too early in RemotePrintJobChild::RecvAbortPrint.
Not sure how this happens, I can only think that nsDocumentViewer is a bit too eager to call nsPrintEngine::Destroy.
Attachment #8715284 - Flags: review?(roc)
Attachment #8715284 - Flags: review?(roc) → review+
Comment on attachment 8715284 [details] [diff] [review] Add null check for mDocViewerPrint in nsPrintEngine::FirePrintingErrorEvent Approval Request Comment [Feature/regressing bug #]: Looks like this was introduced in bug 1199434 in Fx43. [User impact if declined]: This crash will continue to happen sometimes when a printing error occurs or the print is aborted. [Describe test coverage new/current, TreeHerder]: Manually reproduced the crash and tested fix. [Risks and why]: Low - simple null check. [String/UUID change made/needed]: None
Comment on attachment 8715284 [details] [diff] [review] Add null check for mDocViewerPrint in nsPrintEngine::FirePrintingErrorEvent Fix a crash, taking it.
You need to log in before you can comment on or make changes to this bug.