Closed Bug 1245250 Opened 8 years ago Closed 8 years ago

wasm: implement min/max

Categories

(Core :: JavaScript Engine: JIT, defect)

Product:
Core
Component:
JavaScript Engine: JIT
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla47
Tracking Flags:
Tracking Status
firefox47 --- fixed

People

(Reporter: sunfish, Assigned: sunfish)

References

Details

Attachments

(1 file, 1 obsolete file)

wasm-refactor-min-max.patch
6.64 KB, patch
luke
: review+
Details | Diff | Splinter Review
Attached patch wasm-refactor-min-max.patch (obsolete) — — Splinter Review 
This patch refactors asm.js min/max support to handle lowering of variadic arguments before emitting wasm opcodes.
Attachment #8714977 - Flags: review?(luke)
Update patch to re-enable min/max decoding now that the operators are supported.
Attachment #8714977 - Attachment is obsolete: true
Attachment #8714977 - Flags: review?(luke)
Attachment #8714978 - Flags: review?(luke)
Comment on attachment 8714978 [details] [diff] [review]
wasm-refactor-min-max.patch

Review of attachment 8714978 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8714978 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/52e3a5197a92
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: