Fix "Name is not a simple identifier" assertions in clang-plugin

RESOLVED WONTFIX

Status

Firefox Build System
Source Code Analysis
RESOLVED WONTFIX
3 years ago
5 months ago

People

(Reporter: Ehsan, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Some methods may not have names.  NamedDecl::getName() already returns
an empty string for those, but it also asserts the consumer is asking
for something that makes sense.
(Reporter)

Comment 1

3 years ago
Created attachment 8715001 [details] [diff] [review]
Fix "Name is not a simple identifier" assertions in clang-plugin
Attachment #8715001 - Flags: review?(michael)
(Reporter)

Updated

3 years ago
Blocks: 1232038

Comment 2

3 years ago
Comment on attachment 8715001 [details] [diff] [review]
Fix "Name is not a simple identifier" assertions in clang-plugin

Review of attachment 8715001 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM
Attachment #8715001 - Flags: review?(michael) → review+
backed out for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=20982252&repo=mozilla-inbound
Flags: needinfo?(ehsan)
(Reporter)

Comment 6

3 years ago
Hmm, so this is actually wrong.  But I don't have enough time to figure out why.  ;-)  I'll close the bug and we'll keep asserting for now (this is not the only place where we assert.)
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Flags: needinfo?(ehsan)
Resolution: --- → WONTFIX

Updated

5 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.