Closed Bug 1245286 Opened 4 years ago Closed 4 years ago

TSan: data race in js.cpp; ShellRuntime::interruptFunc

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: terrence, Assigned: terrence)

Details

Attachments

(1 file)

The watchdog checks if interruptFunc isNull before reporting. Since interruptFunc is a Value held via PersistentRooted, we have no guarantee that the main thread isn't moving the target function or setting a target function, or any other state.  Instead of looking at the Value, let's add an Atomic flag next to it that we can check.
Attachment #8715013 - Flags: review?(jcoppeard)
Attachment #8715013 - Flags: review?(jcoppeard) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d177f82c65dc92c23865654e6b33deccde5551b
Bug 1245286 - Do not access the shell's interruptFunc off the main thread; r=jonco
https://hg.mozilla.org/mozilla-central/rev/8d177f82c65d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.