1245299 - Calendar l10n repack: IOError: [Errno 2] No such file or directory: '../../dist/bin/application.ini'

Status: RESOLVED INCOMPLETE

(Release Engineering :: General, defect)

Description

[Wayne Mery (:wsmwk)]

Appears to be for every language in every repack of this beta run, for example https://archive.mozilla.org/pub/thunderbird/candidates/45.0b1-candidates/build1/logs/release-comm-beta-win32_repack_1-bm72-build1-build0.txt.gz

Traceback (most recent call last):
  File "c:/builds/moz2_slave/tb-rel-c-beta-w32_rpk_1-000000/comm-beta/mozilla/config/printconfigsetting.py", line 16, in <module>
    with open(file) as fh:
IOError: [Errno 2] No such file or directory: '../../dist/bin/application.ini'


No occurrences in OS build logs

Comment 1

[aleth [:aleth]]

Looks like this happens only during the Lightning repacks: "Repackaging lightning-4.7b1.ast.win32 locale for Language ast"

Relative path issue? (After all, application.ini shouldn't really be missing at any point during repacks, right?)

Comment 2

[aleth [:aleth]]

Still visible in beta 50.

Comment 3

[aleth [:aleth]]

https://ftp.mozilla.org/pub/thunderbird/candidates/50.0b1-candidates/build2/logs/release-comm-beta-linux64_repack_10-bm91-build1-build6.txt.gz

Comment 4

[aleth [:aleth]]

This is the only reference to printconfigsetting.py using application.ini in /calendar: https://dxr.mozilla.org/comm-central/source/calendar/lightning/Makefile.in#90

No idea why it doesn't exist during the calendar repack, but there's some recreate-platform-ini step around as well, so it's not too surprising I suppose. I suspect this could use app.ini instead? Or maybe be removed altogether since nobody seems to have noticed any consequences of it been broken since 45.

Comment 5

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I am not sure where the error is. If this is failing, then the repackaged app.ini should not have BuildID set, right? This doesn't seem to be the case in the  latest betas.

Most of the app.ini code was there because in the repacks there was no platform.ini and it was needed for some other things. If platform.ini is now created then we can prpbably get away with removing app.ini and the surrounding code.

Comment 6

[aleth [:aleth]]

Attachment: Remove obsolete printconfigsetting.py call in calendar Makefile.in

I also don't think this is still needed. Let's just drop the failing call.

Comment 7

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8801113 [details] [diff] [review]
Remove obsolete printconfigsetting.py call in calendar Makefile.in

Review of attachment 8801113 [details] [diff] [review]:
-----------------------------------------------------------------

I don't think we should just drop this without cleanup. MOZ_BUILDID is used in https://dxr.mozilla.org/comm-central/source/calendar/lightning/app.ini#13 and there are other variables there that are required.

If we don't need app.ini anymore because l10n repacks create platform.ini and we can get all the information needed from that it would be great, but in that case the whole app.ini and the lines creating variables for it should be removed. I can imagine maybe the app.ini from en-US is used without change. Can you take a closer look to see why the repacked betas are correctly getting app.ini filled out even though this call fails? And further if we can get rid of app.ini completely?

Comment 8

[aleth [:aleth]]

As far as I can tell, the recreate-platformini step creates a platform.ini from app.ini. app.ini is also used during make ident. I don't think app.ini itself is touched during repacks at all, so of course it would be the en-US version. There doesn't seem to be anything language specific in it anyway.

I don't really understand what the app.ini is all about.

Comment 9

[aleth [:aleth]]

Ah, I think I understand your concern now: these lines may be failing during repacks, but required during the normal build.

Comment 10

[aleth [:aleth]]

(In reply to aleth [:aleth] from comment #9)
> Ah, I think I understand your concern now: these lines may be failing during
> repacks, but required during the normal build.

Good call - leaving out leads to
mozbuild.preprocessor.Error: ('/builds/slave/tb-try-c-cen-l64-0000000000000/build/calendar/lightning/app.ini', 13, 'UNDEFINED_VAR', 'MOZ_BUILDID')