Closed
Bug 1245316
Opened 8 years ago
Closed 8 years ago
Use Rooted and GCVector to implement AutoVectorRooter
Categories
(Core :: JavaScript: GC, defect)
Core
JavaScript: GC
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: terrence, Assigned: terrence)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
19.42 KB,
patch
|
sfink
:
review+
|
Details | Diff | Splinter Review |
We need a trivial shim class to construct the containee and a few places need to get touched up to work with the extra level of indirection. This lets us get rid of AutoVectorRooter and share the implementation with GCVector, giving us a diff of: 13 files changed, 52 insertions(+), 167 deletions(-) https://treeherder.mozilla.org/#/jobs?repo=try&revision=057d74e5478a
Attachment #8715067 -
Flags: review?(sphink)
Updated•8 years ago
|
Attachment #8715067 -
Flags: review?(sphink) → review+
Assignee | ||
Comment 1•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=725c8e45a5db
Assignee | ||
Comment 2•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=9dbc72d56c7a
Assignee | ||
Comment 3•8 years ago
|
||
There are two errors in the try run caused by missing explicit and a changed default size. I've fixed both these errors and am going to go ahead and push without a new try run.
Pushed by tcole@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4ebed327385b Use Rooted<GCVector> to implement AutoVector; r=sfink
Comment 5•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4ebed327385b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 6•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4ebed327385b
You need to log in
before you can comment on or make changes to this bug.
Description
•