Closed Bug 1245316 Opened 8 years ago Closed 8 years ago

Use Rooted and GCVector to implement AutoVectorRooter

Categories

(Core :: JavaScript: GC, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox47 --- affected
firefox52 --- fixed

People

(Reporter: terrence, Assigned: terrence)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We need a trivial shim class to construct the containee and a few places need to get touched up to work with the extra level of indirection. This lets us get rid of AutoVectorRooter and share the implementation with GCVector, giving us a diff of:

13 files changed, 52 insertions(+), 167 deletions(-)

https://treeherder.mozilla.org/#/jobs?repo=try&revision=057d74e5478a
Attachment #8715067 - Flags: review?(sphink)
Attachment #8715067 - Flags: review?(sphink) → review+
There are two errors in the try run caused by missing explicit and a changed default size. I've fixed both these errors and am going to go ahead and push without a new try run.
Pushed by tcole@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ebed327385b
Use Rooted<GCVector> to implement AutoVector; r=sfink
https://hg.mozilla.org/mozilla-central/rev/4ebed327385b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
You need to log in before you can comment on or make changes to this bug.