Closed Bug 1245321 Opened 4 years ago Closed 4 years ago

Merge the object and regexp lists in script data

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

In script data we store regexp objects separately from all other objects. This
was introduced in bug 385729 but it appears to no longer be necessary, and
merging the two lists simplifies things a bit.
This passes all the shell tests locally, and I have started a try run.

I'm not completely certain about the changes to XDR code. Please check that
part carefully!
Attachment #8715070 - Flags: review?(jorendorff)
Comment on attachment 8715070 [details] [diff] [review]
Merge the object and regexp lists in script data

Review of attachment 8715070 [details] [diff] [review]:
-----------------------------------------------------------------

r=me. Thanks for the patch.

::: js/src/vm/Xdr.h
@@ +28,5 @@
>   * this wiki page:
>   *
>   *  https://developer.mozilla.org/en-US/docs/SpiderMonkey/Internals/Bytecode
> + *
> + * (If you're wondering, 0xb973c0de is used because it looks like "bytecode".)

I'm not sure the explanation really improves the joke, but OK. :)
Attachment #8715070 - Flags: review?(jorendorff) → review+
https://hg.mozilla.org/mozilla-central/rev/cddaa4afca59
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.