Closed Bug 1245334 Opened 8 years ago Closed 8 years ago

Make PromiseMessage.jsm ids more meaningful

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla48
Tracking Status
firefox48 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

Details

Attachments

(1 file, 1 obsolete file)

When debugging e10s stuff and using PromiseMessage, it's would be nice to see the name of the message as part of the message id.
Assignee: nobody → mcaceres
Note, I also refactored how the message's clone is created using object.assign().
Attachment #8715096 - Flags: review?(amarchesini)
the above should have read:
Note, I also refactored how the message's data clone is created using object.assign().
Attachment #8715096 - Flags: review?(amarchesini) → review+
Found a small bug: I needed to add the props of "data" to an empty object, and then override the id. 

const dataCopy = Object.assign({}, data, {id});

Otherwise, the original data's id (if one was set) would trash our id.
Carrying over r+
Attachment #8715096 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/8d45b872db49
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.