Closed
Bug 1245334
Opened 8 years ago
Closed 8 years ago
Make PromiseMessage.jsm ids more meaningful
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla48
Tracking | Status | |
---|---|---|
firefox48 | --- | fixed |
People
(Reporter: marcosc, Assigned: marcosc)
Details
Attachments
(1 file, 1 obsolete file)
When debugging e10s stuff and using PromiseMessage, it's would be nice to see the name of the message as part of the message id.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → mcaceres
Assignee | ||
Comment 1•8 years ago
|
||
Note, I also refactored how the message's clone is created using object.assign().
Attachment #8715096 -
Flags: review?(amarchesini)
Assignee | ||
Comment 2•8 years ago
|
||
the above should have read: Note, I also refactored how the message's data clone is created using object.assign().
Assignee | ||
Comment 3•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=7dbaf055ce4c
Updated•8 years ago
|
Attachment #8715096 -
Flags: review?(amarchesini) → review+
Found a small bug: I needed to add the props of "data" to an empty object, and then override the id. const dataCopy = Object.assign({}, data, {id}); Otherwise, the original data's id (if one was set) would trash our id.
Assignee | ||
Comment 6•8 years ago
|
||
Carrying over r+
Attachment #8715096 -
Attachment is obsolete: true
Assignee | ||
Comment 7•8 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=78efefd04609
Keywords: checkin-needed
Comment 9•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8d45b872db49
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox48:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla48
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•