1245353 - tabs.reload has no unit tests

Status: RESOLVED FIXED

(WebExtensions :: Untriaged, defect)

Comment 1

[Andy McKay]

:mattw you moved it into the iteration, so assume you are working on it.

Comment 2

[Matthew Wein [:mattw]]

Attachment: MozReview Request: Bug 1245353 Add tests for tabs.reload r?kmag

Review commit: https://reviewboard.mozilla.org/r/40081/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/40081/

Comment 3

[Matthew Wein [:mattw]]

Do you think this is an adequate test or should we also confirm that the page actually reloads? Do you know if we can do that?

Comment 4

[Kris Maglione [:kmag]]

Comment on attachment 8730684 [details]
MozReview Request: Bug 1245353 Add tests for tabs.reload r?kmag

https://reviewboard.mozilla.org/r/40081/#review36637

It's a start, but we need to do something to check that the tabs actually reload. Loading a page from the extension and having it send a message via `browser.runtime` should work for a start.

We should really try to test `bypassCache` somehow, though. Maybe file a follow-up bug?

::: browser/components/extensions/test/browser/browser_ext_tabs_reload.js:18
(Diff revision 1)
> +        browser.tabs.query({currentWindow: true, active: true}).then(tabs => {
> +          browser.tabs.reload(tabs[0].id, {bypassCache: true}).then(() => {
> +            browser.test.notifyPass("tabs.reload");
> +          });
> +        });
> +      });

Generally you'd phrase this as a promise chain, e.g.,

    browser.tabs.reload().then(() => {
      return browser.tabs.query({currentWindow: true, active: true});
    }).then(tabs => {
      return browser.tabs.reload(tabs[0].id, {bypassCache: true});
    }).then(() => {
      browser.test.notifyPass("tabs.reload");
    });

Comment 5

[Matthew Wein [:mattw]]

Comment on attachment 8730684 [details]
MozReview Request: Bug 1245353 Add tests for tabs.reload r?kmag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40081/diff/1-2/

Comment 6

[Matthew Wein [:mattw]]

Follow up bug created for testing `bypassCache`: https://bugzilla.mozilla.org/show_bug.cgi?id=1257583.

Comment 7

[Kris Maglione [:kmag]]

Comment on attachment 8730684 [details]
MozReview Request: Bug 1245353 Add tests for tabs.reload r?kmag

https://reviewboard.mozilla.org/r/40081/#review37655

Comment 8

[Matthew Wein [:mattw]]

https://reviewboard.mozilla.org/r/40081/#review37655

I created the follow-up Bug 1257583 for testing `bypassCache`.

Comment 9

[Matthew Wein [:mattw]]

Comment on attachment 8730684 [details]
MozReview Request: Bug 1245353 Add tests for tabs.reload r?kmag

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/40081/diff/2-3/

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/28a35458f825

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/28a35458f825