1245371 - browser_AddonWatcher.js is going to permafail when the Gecko version number is bumped to 48

Status: VERIFIED FIXED

(Toolkit :: Performance Monitoring, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Looks like we've got a Telemetry probe expiring on the next merge day. Need to decide what to do with it in the next 4 weeks.

182 INFO TEST-UNEXPECTED-FAIL | toolkit/components/perfmonitoring/tests/browser/browser_AddonWatcher.js | Histogram PERF_MONITORING_SLOW_ADDON_JANK_US is initially empty for the add-on - 11574556 == 0 - JS frame :: chrome://mochitests/content/browser/toolkit/components/perfmonitoring/tests/browser/browser_AddonWatcher.js :: burn_rubber< :: line 94

Comment 1

[David Teller [:Yoric] - still alive but not very active]

We definitely want to keep the probe.

Comment 2

[David Teller [:Yoric] - still alive but not very active]

Attachment: MozReview Request: Bug 1245371 - PERF_MONITORING_SLOW_ADDON_* should not expire in Firefox 49;r=Yoric

Review commit: https://reviewboard.mozilla.org/r/33405/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33405/

Comment 3

[David Teller [:Yoric] - still alive but not very active]

Comment on attachment 8715367 [details]
MozReview Request: Bug 1245371 - PERF_MONITORING_SLOW_ADDON_* should not expire in Firefox 49;r=Yoric

https://reviewboard.mozilla.org/r/33405/#review30127

self-reviewing. This is just a version change in Telemetry.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d8180fcec749

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d8180fcec749

Comment 6

[IU]

I think this patch is responsible for the fact that this addon watcher functionality can no longer be suppressed in about:config

What is the new pref for disabling this thing?  Setting "browser.addon-watch.interval" to "-1" no longer works.

Comment 7

[David Teller [:Yoric] - still alive but not very active]

(In reply to IU from comment #6)
> I think this patch is responsible for the fact that this addon watcher
> functionality can no longer be suppressed in about:config
> 
> What is the new pref for disabling this thing?  Setting
> "browser.addon-watch.interval" to "-1" no longer works.

Nope, not related.

Setting "browser.addon-watch.max-simultaneous-reports" to 0 should do the trick.

Comment 8

[IU]

OK. It would great if Mozilla would stick to one pref that suppresses it.  This is now the third pref.

Regardless, Thanks for the info.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Looks great, thanks!