browser_AddonWatcher.js is going to permafail when the Gecko version number is bumped to 48

VERIFIED FIXED in Firefox 47

Status

()

Toolkit
Performance Monitoring
--
major
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: RyanVM, Assigned: Yoric)

Tracking

unspecified
mozilla47
Points:
---

Firefox Tracking Flags

(firefox47 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Looks like we've got a Telemetry probe expiring on the next merge day. Need to decide what to do with it in the next 4 weeks.

182 INFO TEST-UNEXPECTED-FAIL | toolkit/components/perfmonitoring/tests/browser/browser_AddonWatcher.js | Histogram PERF_MONITORING_SLOW_ADDON_JANK_US is initially empty for the add-on - 11574556 == 0 - JS frame :: chrome://mochitests/content/browser/toolkit/components/perfmonitoring/tests/browser/browser_AddonWatcher.js :: burn_rubber< :: line 94
Flags: needinfo?(dteller)
We definitely want to keep the probe.
Flags: needinfo?(dteller)
Assignee: nobody → dteller
Created attachment 8715367 [details]
MozReview Request: Bug 1245371 - PERF_MONITORING_SLOW_ADDON_* should not expire in Firefox 49;r=Yoric

Review commit: https://reviewboard.mozilla.org/r/33405/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33405/
Attachment #8715367 - Flags: review?(dteller)
Comment on attachment 8715367 [details]
MozReview Request: Bug 1245371 - PERF_MONITORING_SLOW_ADDON_* should not expire in Firefox 49;r=Yoric

https://reviewboard.mozilla.org/r/33405/#review30127

self-reviewing. This is just a version change in Telemetry.
Attachment #8715367 - Flags: review?(dteller) → review+
Keywords: checkin-needed

Comment 5

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d8180fcec749
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47

Comment 6

3 years ago
I think this patch is responsible for the fact that this addon watcher functionality can no longer be suppressed in about:config

What is the new pref for disabling this thing?  Setting "browser.addon-watch.interval" to "-1" no longer works.
(In reply to IU from comment #6)
> I think this patch is responsible for the fact that this addon watcher
> functionality can no longer be suppressed in about:config
> 
> What is the new pref for disabling this thing?  Setting
> "browser.addon-watch.interval" to "-1" no longer works.

Nope, not related.

Setting "browser.addon-watch.max-simultaneous-reports" to 0 should do the trick.

Comment 8

3 years ago
OK. It would great if Mozilla would stick to one pref that suppresses it.  This is now the third pref.

Regardless, Thanks for the info.
(Reporter)

Comment 9

3 years ago
Looks great, thanks!
Status: RESOLVED → VERIFIED
status-firefox47: fixed → verified
You need to log in before you can comment on or make changes to this bug.