1245389 - Scrolling to a log failure line should show lines both before and after the selected line

Status: RESOLVED FIXED

(Tree Management :: Treeherder, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Currently if you click on a failure, the viewer would put the red failure line on the very top of the log area, which is less optimal since some log above the failure line could usually be useful.

Comment 1

[Hassan Ali (:hassan)]

If you have a couple of failures next to each other, putting the clicked failure in the middle might bring confusion with the other errors. The new logviewer bug 1315808 solves the scrolling frustration.

Comment 2

[Ed Morley [:emorley]]

Perhaps a compromise might be to not scroll the failure line to the middle of the panel, but to say 25% of the way down?

Is independent highlight vs line number selection something that the unified log viewer supports?

Comment 3

[Hassan Ali (:hassan)]

Yes, it does support independent highlight vs line number selection. I can take care of it :)

Comment 4

[GitHub Autolander Bot]

Attachment: [treeherder] helfi92:add-scrolling-offset-log-failure > mozilla:master

Comment 5

[Hassan Ali (:hassan)]

I put a demo of this functionality on gh-pages: https://helfi92.github.io/treeherder/ui/

Comment 6

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/bf97730f56b0577e5377f8dc5b3c84f048f8a6ec
Bug 1245389 - Log viewer: Display log lines prior to the selected line

Currently if you click on a failure, the viewer would put the red
failure line on the very top of the log area, which is less optimal
since some log above the failure line could usually be useful. This
commit will add an offset of -7px to a line number so that users can
see the log above a failure line.