Closed Bug 1245398 Opened 4 years ago Closed 4 years ago

Use in-tree script for all mulet tests

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: edgar, Unassigned)

References

Details

Attachments

(1 file)

Bug 1237987 introduces in-tree script for mulet mochitests, it looks like the advancement could be applied to other mulet tests.
Blocks: 1235734
Comment on attachment 8716707 [details]
MozReview Request: Bug 1245398 - Use in-tree script for all mulet tests; r=ahal

https://reviewboard.mozilla.org/r/33921/#review30707

Thanks, this looks good!

::: testing/taskcluster/scripts/tester/test-mulet.sh:119
(Diff revision 1)
> -  python2.7 $WORKSPACE/${MOZHARNESS_SCRIPT} ${config_cmds} "${@}"
> +  python2.7 $WORKSPACE/${MOZHARNESS_SCRIPT} ${config_cmds} ${gaia_dir} "${@}"

I'm rusty on my shell.. this will just be an empty string if not defined, right?
Attachment #8716707 - Flags: review?(ahalberstadt) → review+
https://reviewboard.mozilla.org/r/33921/#review30707

> I'm rusty on my shell.. this will just be an empty string if not defined, right?

Ah, it is a typo, it should be `gaia_cmd` instead. I will correct it and trigger a try run again. Thank you.
Comment on attachment 8716707 [details]
MozReview Request: Bug 1245398 - Use in-tree script for all mulet tests; r=ahal

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33921/diff/1-2/
Attachment #8716707 - Attachment description: MozReview Request: Bug 1245398 - Use in-tree script for all mulet tests; r?ahal → MozReview Request: Bug 1245398 - Use in-tree script for all mulet tests; r=ahal
https://hg.mozilla.org/mozilla-central/rev/743e215cdb2c
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.