1245408 - [TV][Seamless experience] ESC to Backspace (Keyboard event change)

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

Description

[Cynthia Tang [:cynthiatang]]

STR: 
 1. Sent Tab to TV
 2. Press Back (Backspace key)

Expect result:
 - The video will pause and ask if user want to leave.
 - Dialog Body: Do you want to end video playback?

Actual Result:
 - Nothing happened

======================
Build ID               20160201030209
Gaia Revision          10df3a68103c4ae7bd033eb0a742deb59c01b3bf
Gaia Date              2016-02-02 19:13:16
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/941033a51983ddec2d99aa9f868a54c0196a4075
Gecko Version          46.0a1
Device Name            hammerhead
Firmware(Release)      5.1.1
Firmware(Incremental)  eng.cltbld.20160201.063447
Firmware Date          Mon Feb  1 06:35:05 EST 2016
Bootloader             HHZ12f

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] Fischer-L:bug_1245408-fling-payer-back-key-event-update > mozilla-b2g:master

Comment 2

[Fischer [:Fischer]]

Comment on attachment 8715209 [details] [review]
[gaia] Fischer-L:bug_1245408-fling-payer-back-key-event-update > mozilla-b2g:master

@rex,
The patch changes to the newly updated 'back-keyup' event in the KeyNavigationAdapter, thank you

Comment 3

[Fischer [:Fischer]]

[Blocking Requested - why for this release]:

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8715209 [details] [review]
[gaia] Fischer-L:bug_1245408-fling-payer-back-key-event-update > mozilla-b2g:master

So did you confirmed that we are not going to use esc for quitting anymore? If yes you can land it.

Comment 5

[Fischer [:Fischer]]

Land to master: https://github.com/mozilla-b2g/gaia/commit/6c51b3909aae5962de21f6f24c69ac395e42c07a

Comment 6

[Fischer [:Fischer]]

Comment on attachment 8715209 [details] [review]
[gaia] Fischer-L:bug_1245408-fling-payer-back-key-event-update > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1245408
[User impact] if declined: Unable to end video when pressing back key
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low
[String changes made]: No

Comment 7

[Josh Cheng [:josh]]

Comment on attachment 8715209 [details] [review]
[gaia] Fischer-L:bug_1245408-fling-payer-back-key-event-update > mozilla-b2g:master

Approved for TV 2.5

Comment 8

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/539426ab21abb43b3a5addcd42f5f7f3dd1bad57

Comment 9

[Cynthia Tang [:cynthiatang]]

Verified on v2.5 and Master

Master
Serial: 0688039f439c66e4 (State: device)
Build ID               20160223150255
Gaia Revision          e0c9692073da86f91b348b1527dda1bbfc2f404b
Gaia Date              2016-02-23 21:06:20
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a9e33d8c48b5ca93ca1937eba4220f681a0f05ec
Gecko Version          47.0a1
Device Name            hammerhead
Firmware(Release)      5.1.1
Firmware(Incremental)  eng.cltbld.20160223.200438
Firmware Date          Tue Feb 23 20:04:56 EST 2016
Bootloader             HHZ12f

v2.5
Build ID               20160223150255
Gaia Revision          b059a19c4cb615e16174735662199e6769cee393
Gaia Date              2016-02-23 15:29:43
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/a9e33d8c48b5ca93ca1937eba4220f681a0f05ec
Gecko Version          47.0a1
Device Name            hammerhead
Firmware(Release)      5.1.1
Firmware(Incremental)  eng.cltbld.20160223.200438
Firmware Date          Tue Feb 23 20:04:56 EST 2016
Bootloader             HHZ12f