Update FENNEC_GECKOAPP_STARTUP_ACTION to measure homescreen shortcut launches

RESOLVED FIXED in Firefox 46

Status

()

RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Margaret, Assigned: Margaret)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 47
Points:
---

Firefox Tracking Flags

(firefox45 affected, firefox46 fixed, firefox47 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

3 years ago
Right now we measure if Fennec was launched from the main action, URL intent, web app, or restricted/guest profiles. We should add another case for apps launched from homescreen shortcuts.
(Assignee)

Comment 1

3 years ago
So, I'm not sure this is actually what we want to do. We only record this measurement on startup, so we won't count "launching" from a homescreen shortcut if the browser is already running.

I want to compare the different ways people get back into the browser, so maybe I need a new histogram for that.
(In reply to :Margaret Leibovic from comment #1)
> So, I'm not sure this is actually what we want to do. We only record this
> measurement on startup, so we won't count "launching" from a homescreen
> shortcut if the browser is already running.
> 
> I want to compare the different ways people get back into the browser, so
> maybe I need a new histogram for that.

Wow. If that histogram only counts the actual "launch" (onCreate) and not subsequent opens (onNewIntent) then we have a problem that should be fixed.
(Assignee)

Comment 3

3 years ago
(In reply to Mark Finkle (:mfinkle) from comment #2)
> (In reply to :Margaret Leibovic from comment #1)
> > So, I'm not sure this is actually what we want to do. We only record this
> > measurement on startup, so we won't count "launching" from a homescreen
> > shortcut if the browser is already running.
> > 
> > I want to compare the different ways people get back into the browser, so
> > maybe I need a new histogram for that.
> 
> Wow. If that histogram only counts the actual "launch" (onCreate) and not
> subsequent opens (onNewIntent) then we have a problem that should be fixed.

Okay, I'll make two commits.

1) Add new homescreen shortcut startup action
2) Make the measurement in onNewIntent as well as on startup
(Assignee)

Comment 4

3 years ago
Created attachment 8715358 [details]
MozReview Request: Bug 1245497 - (Part 1) Update FENNEC_GECKOAPP_STARTUP_ACTION to measure homescreen shortcut launches. r=mcomella

Review commit: https://reviewboard.mozilla.org/r/33395/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33395/
Attachment #8715358 - Flags: review?(michael.l.comella)
(Assignee)

Comment 5

3 years ago
Created attachment 8715359 [details]
MozReview Request: Bug 1245497 - (Part 2) Measure FENNEC_GECKOAPP_STARTUP_ACTION when we handle a new intent. r=mcomella

Review commit: https://reviewboard.mozilla.org/r/33397/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33397/
Attachment #8715359 - Flags: review?(michael.l.comella)
(Assignee)

Comment 6

3 years ago
I decided to prioritize guest/restricted profiles over homescreen shortcuts. So, this won't count homescreen shortcuts launched by users in restricted profiles, but that's an edge case, so I'm not worried about it.
Comment on attachment 8715358 [details]
MozReview Request: Bug 1245497 - (Part 1) Update FENNEC_GECKOAPP_STARTUP_ACTION to measure homescreen shortcut launches. r=mcomella

https://reviewboard.mozilla.org/r/33395/#review31325
Attachment #8715358 - Flags: review?(michael.l.comella) → review+
Attachment #8715359 - Flags: review?(michael.l.comella) → review+
Comment on attachment 8715359 [details]
MozReview Request: Bug 1245497 - (Part 2) Measure FENNEC_GECKOAPP_STARTUP_ACTION when we handle a new intent. r=mcomella

https://reviewboard.mozilla.org/r/33397/#review31327

::: mobile/android/base/java/org/mozilla/gecko/GeckoApp.java:1942
(Diff revision 1)
> +        Telemetry.addToHistogram("FENNEC_GECKOAPP_STARTUP_ACTION", startupAction.ordinal());

This will change the metrics this histogram is measuring – should we rename the histogram in order to make that distinction clear?
I'd argue that "guest" and "restricted" are the values that changed this metric. Those are different profiles. The "homescreen" aspect is just a type of startup.
(Assignee)

Comment 10

3 years ago
Mike's comment is on the change to add a measurement in onNewIntent, so I assume he's talking about the change in the actual meaning of the measurement.

I don't think we need to change the histogram name because we're just updating it to measure what we intended to measure.

Does that make sense? Should I land this as-is?
Flags: needinfo?(michael.l.comella)
Flags: needinfo?(mark.finkle)
I'm fine with landing as-is
Flags: needinfo?(mark.finkle)
(In reply to :Margaret Leibovic from comment #10)
> I don't think we need to change the histogram name because we're just
> updating it to measure what we intended to measure.

Provided we remember not to conflate this with the previous results (e.g. a year from now, are we going to remember that the data before the day this lands is invalid and should be ignored?), I'm okay with landing as-is.
Flags: needinfo?(michael.l.comella)
(Assignee)

Comment 13

3 years ago
https://hg.mozilla.org/integration/fx-team/rev/a6eb009fc4537162dbe97b1202e6aa033f7278d9
Bug 1245497 - (Part 1) Update FENNEC_GECKOAPP_STARTUP_ACTION to measure homescreen shortcut launches. r=mcomella

https://hg.mozilla.org/integration/fx-team/rev/5ea830f5a8c358bffa34cc1934fedcaf09a870b9
Bug 1245497 - (Part 2) Measure FENNEC_GECKOAPP_STARTUP_ACTION when we handle a new intent. r=mcomella

Comment 14

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a6eb009fc453
https://hg.mozilla.org/mozilla-central/rev/5ea830f5a8c3
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
(Assignee)

Comment 15

3 years ago
Comment on attachment 8715358 [details]
MozReview Request: Bug 1245497 - (Part 1) Update FENNEC_GECKOAPP_STARTUP_ACTION to measure homescreen shortcut launches. r=mcomella

Approval Request Comment

[Feature/regressing bug #]: Progressive web apps initiative. 

[User impact if declined]: We won't know how often users launch homescreen shortcuts (aka progressive web apps).

[Describe test coverage new/current, TreeHerder]: Tested locally, no automated tests.

[Risks and why]: Low-risk, adds a telemetry probe. This does touch logic in the startup path, so I would be okay with landing in Aurora first to make sure there are no unexpected issues before landing on beta.

[String/UUID change made/needed]: None.
Attachment #8715358 - Flags: approval-mozilla-beta?
Attachment #8715358 - Flags: approval-mozilla-aurora?
status-firefox45: --- → affected
status-firefox46: --- → affected
Comment on attachment 8715358 [details]
MozReview Request: Bug 1245497 - (Part 1) Update FENNEC_GECKOAPP_STARTUP_ACTION to measure homescreen shortcut launches. r=mcomella

I would prefer to see that riding the train from 46 as we are late in the cycle
(only taking important fixes).
Attachment #8715358 - Flags: approval-mozilla-beta?
Attachment #8715358 - Flags: approval-mozilla-beta-
Attachment #8715358 - Flags: approval-mozilla-aurora?
Attachment #8715358 - Flags: approval-mozilla-aurora+
https://bugzilla.mozilla.org/show_bug.cgi?id=1245497
status-firefox46: affected → fixed
You need to log in before you can comment on or make changes to this bug.