Closed Bug 1245521 Opened 8 years ago Closed 8 years ago

TP UI Tour should return to the previous page when closing the tour at step 2

Categories

(www.mozilla.org :: Pages & Content, defect)

Production
All
Unspecified
defect
Not set
normal

Tracking

(firefox47 affected)

RESOLVED FIXED
Tracking Status
firefox47 --- affected

People

(Reporter: pauly, Assigned: agibson)

References

Details

(Whiteboard: [fxprivacy])

Attachments

(1 file)

[Affected versions]:
47.0a1

[Affected platforms]:
Win 7 x64, Ubuntu 12.04 x86, OS X 10.10.5

[Steps to reproduce]:
1. Start FF with a new profile
2. Open about:preferences#privacy and set TP="always"
3. Open cnn.com
4. In the TP Tour displayed, proceed to the step 2
5. Close the Tour from the "X" button

[Expected result]:
The tour tab should close and I should be returned to cnn.com

[Actual result]:
"Restart tour" page displayed
CC'ing Jauvan for thoughts here - if we closed the tab when clicking (x) to close on step 2, then the user has no way to finish the tour (hence why the restart button could still be useful at this step).
Flags: needinfo?(jmoradi)
Whiteboard: [fxprivacy][triage]
Whiteboard: [fxprivacy][triage] → [fxprivacy]
Hi Alex, this is something we'd want to fix, but it's lower priority for two reasons:
1. It's edge case to begin with
2. This only happens on the alt path into the tour, which is from the Doorhanger on first blocking of tracking loads *outside* pbm. 

For #2, TP outside PBM is not on the trains, so we have a lot of time. 

I would mark this p3. We would fix it, but it doesn't increase in priority until we have a timeline for getting it out of PBM
Flags: needinfo?(jmoradi)
(In reply to Javaun Moradi [:javaun] from comment #2)
> Hi Alex, this is something we'd want to fix, but it's lower priority for two
> reasons:
> 1. It's edge case to begin with
> 2. This only happens on the alt path into the tour, which is from the
> Doorhanger on first blocking of tracking loads *outside* pbm. 
> 
> For #2, TP outside PBM is not on the trains, so we have a lot of time. 
> 
> I would mark this p3. We would fix it, but it doesn't increase in priority
> until we have a timeline for getting it out of PBM

Ok thanks - this is a fairly simple code change. I will add it to our sprint backlog and pick it up over the next few weeks. Thanks for the feedback!
Assignee: nobody → agibson
Status: NEW → ASSIGNED
Attached file GitHub pull request
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/c94e3884b7f2693b9c4ad0189c945590c8e42004
[fix bug 1245521] TP Tour should always try and close tab when info panels are dismissed

https://github.com/mozilla/bedrock/commit/1795a18e966b7abb07b45ce57a2ab3c108b91808
Merge pull request #3863 from alexgibson/bug-1245521-tp-tour-close-tab-panel

[fix bug 1245521] TP Tour should always try and close tab when info panels are dismissed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: