1245534 - Request Plugins Doorhanger is poorly formatted

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Sevaan Franks [:sevaan]]

Attachment: Request Plugins Doorhanger

The formatting of the Request Plugins doorhanger is broken.

Comment 1

[:Gijs (he/him)]

I don't see this on beta. Can you:

- reproduce on a clean profile?
- if so, can you check if this is a regression using mozregression (e.g. mozregression --good 44) ?

Comment 2

[Sevaan Franks [:sevaan]]

When I tried on a fresh profile, I saw an infobar this time, instead of the doorhanger. However, when I clicked the plugins icon in the URL bar, the doorhanger opens with the same errors.

http://i.sevaan.com/3E110L45331U
http://i.sevaan.com/1D0h2R242v0i

Comment 3

[Sevaan Franks [:sevaan]]

(In reply to :Gijs Kruitbosch from comment #1)
> - if so, can you check if this is a regression using mozregression (e.g.
> mozregression --good 44) ?

How do I do this?

Comment 4

[:Gijs (he/him)]

(In reply to Sevaan Franks [:sevaan] from comment #3)
> (In reply to :Gijs Kruitbosch from comment #1)
> > - if so, can you check if this is a regression using mozregression (e.g.
> > mozregression --good 44) ?
> 
> How do I do this?

http://mozilla.github.io/mozregression/install.html

If you have a Firefox source tree, you can also use: ./mach mozregression, with the same parameters as 'normal' mozregression.

If not, install it and then run either the GUI or the commandline client. The `mozregression --good 44` instruction will work for the commandline version. I've not tried the GUI one, but the principle is the same: bisect some range (in this case, from 44-on-nightly, so sometime last year, to now) to figure out when an issue was introduced. Feel free to ping me on IRC if you need more help. :-)

Comment 5

[Sevaan Franks [:sevaan]]

Just an update that the issues seems to have been resolved. Not sure which Nightly update fixed this, but I just noticed and am unable to replicate the issue anymore.

Comment 6

[:Gijs (he/him)]

Alright, thanks!