Closed Bug 1245556 Opened 8 years ago Closed 3 years ago

Dismiss Tab Queue Notification Permission from notification bar when choosing "Go to Settings"

Categories

(Firefox for Android Graveyard :: Overlays, defect)

47 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox47 affected)

RESOLVED INCOMPLETE
Tracking Status
firefox47 --- affected

People

(Reporter: TeoVermesan, Unassigned, Mentored)

Details

(Whiteboard: [lang=java][good next bug])

Steps to reproduce:

1. Enable "Draw over other apps" option so you can enable "Open multiple links option" from settings
2. Now Disable "Draw over other apps"
3. Go to gmail.com and tap on an article
4. From the android notification bar choose "Go to Settings"

Actual results:
- "Draw over other apps" option is enabled but the notification is still displayed in the notification bar

Expected results:
- The notification should disappear after choosing to go to Settings and the "Draw over other apps" option is enabled
Assignee: nobody → s.kaspari
We set "auto cancel" on the notification: This will dismiss the notification if the user clicks on it. However this does not happen if the user selects the action ("Go to Settings").

From within Android's settings we can't run code to dismiss the notification. This means we could only dismiss it if we either route the click through our app ("Go to settings" -> Firefox -> Android's settings) or dismiss it the next time the user enters the app. Of course the user can dismiss the notification herself at any time.

@Antlam: What's your take on this?
Flags: needinfo?(alam)
I think we should get rid of the notification as soon as a user presses the action button on the notification.
Flags: needinfo?(alam)
Assignee: s.kaspari → nobody
Mentor: s.kaspari
Whiteboard: [lang=java][good next bug]
Hi, guide me on this one ?
Hey Sebastian!

If this is still doable, I would like to work on this.

I looked into the code and done some research of my own, but I was not able to find a way to cancel notification when "Go to Settings" is clicked. I think the only way is as you suggested "we either route the click through our app ("Go to settings" -> Firefox -> Android's settings)", but I think this will incur a lot of overhead processing. So what's your take on this, should we do this or not? Or is there any other way around to do this?

Regards.
Flags: needinfo?(s.kaspari)
Hey Shatur! I agree with you that the added complexity might not be worth it. Overall this is an edge case: We ask explicitly for the permission when enabling tab queues (and you can't without it). So you only hit this if you revoke the permission manually after enabling tab queue. And finally there are some upcoming changes in Android O for overlays, so we might rethink our approach completely: https://developer.android.com/preview/behavior-changes.html#cwt

Are you looking for a bug to contribute? Maybe bug 1310620? But it might require having a Chromecast.
Flags: needinfo?(s.kaspari)
Hii!
(In reply to Sebastian Kaspari (:sebastian) from comment #5)
> Are you looking for a bug to contribute? Maybe bug 1310620? But it might
> require having a Chromecast.

Yep, I was looking for a bug to contribute, but unfortunately, I don't have chromecast:(. I will try to find another bug:).

Thanks!
We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → INCOMPLETE
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.