1245562 - Playbackrate button in the animation panel toolbar should not be bound with animation.playbackRate

Status: REOPENED

(DevTools :: Inspector: Animations, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: keyframes.html

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:44.0) Gecko/20100101 Firefox/44.0
Build ID: 20160123151951

Steps to reproduce:

1. Open attachment
2 [review]. Open the devtools
3. Select the body element in the inspector panel
4. On the side-panel, go to the "Animations" tab
5. Select the 2x pl


Actual results:

The animation timeline header is updated, showing an overall 5s total animation duration ( was previously 10s ).

Typing the following in the console :
 
> $("div").getAnimations()[0].playbackRate

Will output : "2"




Expected results:

The animation timeline header should not be updated and still show a 10s animation duration.
If played, the animation scrubber should move 2 times slower than in "1x" mode.

The command :

> $("div").getAnimations()[0].playbackRate

Should output : "1"

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

The name of the playbackRate button could be misleading here, I will refer to it as "speedRate button" in the following.

---

As discussed on IRC with pbrosset, I think the speedRate button in the toolbar should not affect how time is displayed in the animation timeline, but rather affect how fast the scrubber move.
At the same time, the animation.playbackRate ( set by javascript ), should be more visible ( currently, you have to hover the animation block to see it ).
With those change, the animation panel would be able to deal with multiple playbackRates ( currently, when there are differents playbackRates, we show a "-" in the speedRate button ). 

This could be difficult to do as, for now, it uses animation.playbackRate in order to play the animations to the selected rate. pbrosset evoked GroupEffects to deal with this ( http://danielcwilson.com/blog/2015/09/animations-part-4/ ), but this is not in the WebAnimation API Level 1 spec.

I hope I made this clear enough. 
Feel free to tell me if not, I will happily provide screenshots/video if needed.

Comment 2

[Patrick Brosset <:pbro>]

Filter on CLIMBING SHOES

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1245562 - Add animationsPlayBackRateMultiplier BrowsingContext flag. r=hiro,boris.

The flag will be set from DevTools to control the playback rate of all animations
in the page.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cf9c6759ce6f
https://hg.mozilla.org/integration/autoland/rev/e3e77b93583a
Add animationsPlayBackRateMultiplier BrowsingContext flag. r=hiro.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/71b8fe687b34
https://hg.mozilla.org/integration/autoland/rev/fbc8640ae274
Revert "Bug 1245562 - Add animationsPlayBackRateMultiplier BrowsingContext flag. r=hiro." on request for being attached to the wrong bug

Comment 6

[Phabricator Automation]

Comment on attachment 9538076 [details]
Bug 1245562 - Add animationsPlayBackRateMultiplier BrowsingContext flag. r=hiro,boris.

Revision D279259 was moved to bug 2011224. Setting attachment 9538076 [details] to obsolete.

Comment 7

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e3e77b93583a

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Norisz Fay [:noriszfay] from comment #7)

https://hg.mozilla.org/mozilla-central/rev/e3e77b93583a

wasn't the patch backed out?