1245576 - Add missing unsave.1 UI Telemetry for removing bookmarks and readinglist items from Home Panels

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: more-unsave-probes v0.1

We track the "action.1 > contextmenu > home_remove" usage, but for Bookmarks and ReadingList items we should also be triggering unsave.1 probes.

This patch adds the probes.

Note: we try to put probes as close to the UI as possible, which is why we don't just add the probes to the DB code itself. We lose a lot of context by pushing probes down, deep into the code.

Comment 1

[:Margaret Leibovic]

Comment on attachment 8715380 [details] [diff] [review]
more-unsave-probes v0.1

Review of attachment 8715380 [details] [diff] [review]:
-----------------------------------------------------------------

Could be good to create a "UI telemetry philosophy" document. Hint hint...

Comment 2

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/148870861645

Comment 3

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/148870861645

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8715380 [details] [diff] [review]
more-unsave-probes v0.1

Approval Request Comment
[Feature/regressing bug #]: -
[User impact if declined]: Less complete telemetry collection
[Describe test coverage new/current, TreeHerder]: Landed on Nightly
[Risks and why]: Low risk probes
[String/UUID change made/needed]: none

Comment 5

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8715380 [details] [diff] [review]
more-unsave-probes v0.1

Moar probes, taking it. Should be in 45 beta 4

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/fe9ce50ba52a

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-beta/rev/83408c1a9d8a