Add missing unsave.1 UI Telemetry for removing bookmarks and readinglist items from Home Panels

RESOLVED FIXED in Firefox 45

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: mfinkle, Assigned: mfinkle)

Tracking

unspecified
Firefox 47
Points:
---

Firefox Tracking Flags

(firefox45 fixed, firefox46 fixed, firefox47 fixed)

Details

Attachments

(1 attachment)

Created attachment 8715380 [details] [diff] [review]
more-unsave-probes v0.1

We track the "action.1 > contextmenu > home_remove" usage, but for Bookmarks and ReadingList items we should also be triggering unsave.1 probes.

This patch adds the probes.

Note: we try to put probes as close to the UI as possible, which is why we don't just add the probes to the DB code itself. We lose a lot of context by pushing probes down, deep into the code.
Attachment #8715380 - Flags: review?(margaret.leibovic)

Comment 1

2 years ago
Comment on attachment 8715380 [details] [diff] [review]
more-unsave-probes v0.1

Review of attachment 8715380 [details] [diff] [review]:
-----------------------------------------------------------------

Could be good to create a "UI telemetry philosophy" document. Hint hint...
Attachment #8715380 - Flags: review?(margaret.leibovic) → review+

Updated

2 years ago
Assignee: nobody → mark.finkle

Comment 2

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/148870861645

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/148870861645
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment on attachment 8715380 [details] [diff] [review]
more-unsave-probes v0.1

Approval Request Comment
[Feature/regressing bug #]: -
[User impact if declined]: Less complete telemetry collection
[Describe test coverage new/current, TreeHerder]: Landed on Nightly
[Risks and why]: Low risk probes
[String/UUID change made/needed]: none
Attachment #8715380 - Flags: approval-mozilla-beta?
Attachment #8715380 - Flags: approval-mozilla-aurora?
status-firefox45: --- → affected
status-firefox46: --- → affected
Comment on attachment 8715380 [details] [diff] [review]
more-unsave-probes v0.1

Moar probes, taking it. Should be in 45 beta 4
Attachment #8715380 - Flags: approval-mozilla-beta?
Attachment #8715380 - Flags: approval-mozilla-beta+
Attachment #8715380 - Flags: approval-mozilla-aurora?
Attachment #8715380 - Flags: approval-mozilla-aurora+

Comment 6

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/fe9ce50ba52a
status-firefox46: affected → fixed

Comment 7

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/83408c1a9d8a
status-firefox45: affected → fixed
You need to log in before you can comment on or make changes to this bug.