Closed Bug 1245576 Opened 6 years ago Closed 5 years ago

Add missing unsave.1 UI Telemetry for removing bookmarks and readinglist items from Home Panels

Categories

(Firefox for Android Graveyard :: General, defect)

defect
Not set
normal

Tracking

(firefox45 fixed, firefox46 fixed, firefox47 fixed)

RESOLVED FIXED
Firefox 47
Tracking Status
firefox45 --- fixed
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: mfinkle, Assigned: mfinkle)

Details

Attachments

(1 file)

We track the "action.1 > contextmenu > home_remove" usage, but for Bookmarks and ReadingList items we should also be triggering unsave.1 probes.

This patch adds the probes.

Note: we try to put probes as close to the UI as possible, which is why we don't just add the probes to the DB code itself. We lose a lot of context by pushing probes down, deep into the code.
Attachment #8715380 - Flags: review?(margaret.leibovic)
Comment on attachment 8715380 [details] [diff] [review]
more-unsave-probes v0.1

Review of attachment 8715380 [details] [diff] [review]:
-----------------------------------------------------------------

Could be good to create a "UI telemetry philosophy" document. Hint hint...
Attachment #8715380 - Flags: review?(margaret.leibovic) → review+
Assignee: nobody → mark.finkle
https://hg.mozilla.org/mozilla-central/rev/148870861645
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Comment on attachment 8715380 [details] [diff] [review]
more-unsave-probes v0.1

Approval Request Comment
[Feature/regressing bug #]: -
[User impact if declined]: Less complete telemetry collection
[Describe test coverage new/current, TreeHerder]: Landed on Nightly
[Risks and why]: Low risk probes
[String/UUID change made/needed]: none
Attachment #8715380 - Flags: approval-mozilla-beta?
Attachment #8715380 - Flags: approval-mozilla-aurora?
Comment on attachment 8715380 [details] [diff] [review]
more-unsave-probes v0.1

Moar probes, taking it. Should be in 45 beta 4
Attachment #8715380 - Flags: approval-mozilla-beta?
Attachment #8715380 - Flags: approval-mozilla-beta+
Attachment #8715380 - Flags: approval-mozilla-aurora?
Attachment #8715380 - Flags: approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.