Closed Bug 1245586 Opened 4 years ago Closed 4 years ago

add debugging aids for thread shutdown

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

These bits were helpful in debugging recent thread shutdown leaks.
Comment on attachment 8715408 [details] [diff] [review]
add debugging aids for thread shutdown

Review of attachment 8715408 [details] [diff] [review]:
-----------------------------------------------------------------

::: xpcom/threads/nsThread.cpp
@@ +524,5 @@
> +  // requesting shutdown on another, which can be helpful for diagnosing
> +  // the leak.
> +  for (size_t i = 0; i < mRequestedShutdownContexts.Length(); ++i) {
> +    Unused << mRequestedShutdownContexts[i].forget();
> +  }

#ifdef DEBUG, perhaps?
Attachment #8715408 - Flags: review?(khuey) → review+
https://hg.mozilla.org/mozilla-central/rev/9b261217646e
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.