1245589 - Map commits to review requests based on MozReview-Commit-ID

Status: RESOLVED FIXED

(MozReview Graveyard :: General, defect)

Description

[Gregory Szorc [:gps]]

Git and Mercurial are now both adding MozReview-Commit-ID annotations to commit messages. These annotations can be used to better map incoming commits to existing review requests.

Use of these annotations should address a lot of complaints people have where MozReview assigns a new, unrelated commit to an existing review request. This occurs when history rewriting occurs, for example.

Comment 1

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozautomation: establish API for parsing out commit IDs (bug 1245589); r?dminor

It is a simple function. But we will have multiple callers. So best to
establish a reusable function.

MozReview-Commit-ID: ByDAiV1uSK7

Review commit: https://reviewboard.mozilla.org/r/33455/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33455/

Comment 2

[Gregory Szorc [:gps]]

Attachment: MozReview Request: reviewboard: use parse_commit_id (bug 1245589); r?dminor

We have a dedicated function for this now. Use it.

Also convert the description to a str so we are passing around the raw
bytes as opposed to whatever Mercurial has munged it to for local
representation.

MozReview-Commit-ID: 3fXxsiMak9Q

Review commit: https://reviewboard.mozilla.org/r/33457/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33457/

Comment 3

[Gregory Szorc [:gps]]

Attachment: MozReview Request: mozreview: map commits to review requests based on commit ID (bug 1245589); r?dminor

TODO need to update docs

MozReview-Commit-ID: IF9JojPZBmS

Review commit: https://reviewboard.mozilla.org/r/33459/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33459/

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 8715446 [details]
MozReview Request: mozautomation: establish API for parsing out commit IDs (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33455/diff/1-2/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8715447 [details]
MozReview Request: reviewboard: use parse_commit_id (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33457/diff/1-2/

Comment 6

[Gregory Szorc [:gps]]

Comment on attachment 8715448 [details]
MozReview Request: mozreview: map commits to review requests based on commit ID (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33459/diff/1-2/

Comment 7

[Gregory Szorc [:gps]]

Comment on attachment 8715446 [details]
MozReview Request: mozautomation: establish API for parsing out commit IDs (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33455/diff/2-3/

Comment 8

[Gregory Szorc [:gps]]

Comment on attachment 8715447 [details]
MozReview Request: reviewboard: use parse_commit_id (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33457/diff/2-3/

Comment 9

[Gregory Szorc [:gps]]

Comment on attachment 8715448 [details]
MozReview Request: mozreview: map commits to review requests based on commit ID (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33459/diff/2-3/

Comment 10

[Dan Minor [:dminor]]

Comment on attachment 8715446 [details]
MozReview Request: mozautomation: establish API for parsing out commit IDs (bug 1245589); r?dminor

https://reviewboard.mozilla.org/r/33455/#review30585

Comment 11

[Dan Minor [:dminor]]

Comment on attachment 8715447 [details]
MozReview Request: reviewboard: use parse_commit_id (bug 1245589); r?dminor

https://reviewboard.mozilla.org/r/33457/#review30587

Comment 12

[Dan Minor [:dminor]]

Comment on attachment 8715448 [details]
MozReview Request: mozreview: map commits to review requests based on commit ID (bug 1245589); r?dminor

https://reviewboard.mozilla.org/r/33459/#review30589

Comment 13

[Gregory Szorc [:gps]]

https://hg.mozilla.org/hgcustom/version-control-tools/rev/28bd62e8782097f1e0dc8b174853db1be5584156
mozautomation: establish API for parsing out commit IDs (bug 1245589); r=dminor

https://hg.mozilla.org/hgcustom/version-control-tools/rev/09518d2261c53c2d6cb9578445ddcf8e1c576a55
reviewboard: use parse_commit_id (bug 1245589); r=dminor

https://hg.mozilla.org/hgcustom/version-control-tools/rev/7737e110fd90a70ee52f22869bbff6fea817e22a
mozreview: map commits to review requests based on commit ID (bug 1245589); r=dminor