Map commits to review requests based on MozReview-Commit-ID

RESOLVED FIXED

Status

defect
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

Details

Attachments

(3 attachments)

Git and Mercurial are now both adding MozReview-Commit-ID annotations to commit messages. These annotations can be used to better map incoming commits to existing review requests.

Use of these annotations should address a lot of complaints people have where MozReview assigns a new, unrelated commit to an existing review request. This occurs when history rewriting occurs, for example.
It is a simple function. But we will have multiple callers. So best to
establish a reusable function.

MozReview-Commit-ID: ByDAiV1uSK7

Review commit: https://reviewboard.mozilla.org/r/33455/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33455/
Attachment #8715446 - Flags: review?(dminor)
We have a dedicated function for this now. Use it.

Also convert the description to a str so we are passing around the raw
bytes as opposed to whatever Mercurial has munged it to for local
representation.

MozReview-Commit-ID: 3fXxsiMak9Q

Review commit: https://reviewboard.mozilla.org/r/33457/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33457/
Attachment #8715447 - Flags: review?(dminor)
Comment on attachment 8715446 [details]
MozReview Request: mozautomation: establish API for parsing out commit IDs (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33455/diff/1-2/
Comment on attachment 8715447 [details]
MozReview Request: reviewboard: use parse_commit_id (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33457/diff/1-2/
Attachment #8715448 - Attachment description: MozReview Request: INCOMPLETE mozreview: map commits to review requests based on commit ID (bug 1245589) → MozReview Request: mozreview: map commits to review requests based on commit ID (bug 1245589); r?dminor
Attachment #8715448 - Flags: review?(dminor)
Comment on attachment 8715448 [details]
MozReview Request: mozreview: map commits to review requests based on commit ID (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33459/diff/1-2/
Comment on attachment 8715446 [details]
MozReview Request: mozautomation: establish API for parsing out commit IDs (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33455/diff/2-3/
Comment on attachment 8715447 [details]
MozReview Request: reviewboard: use parse_commit_id (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33457/diff/2-3/
Comment on attachment 8715448 [details]
MozReview Request: mozreview: map commits to review requests based on commit ID (bug 1245589); r?dminor

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33459/diff/2-3/
Comment on attachment 8715446 [details]
MozReview Request: mozautomation: establish API for parsing out commit IDs (bug 1245589); r?dminor

https://reviewboard.mozilla.org/r/33455/#review30585
Attachment #8715446 - Flags: review?(dminor) → review+
Comment on attachment 8715447 [details]
MozReview Request: reviewboard: use parse_commit_id (bug 1245589); r?dminor

https://reviewboard.mozilla.org/r/33457/#review30587
Attachment #8715447 - Flags: review?(dminor) → review+
Attachment #8715448 - Flags: review?(dminor) → review+
Comment on attachment 8715448 [details]
MozReview Request: mozreview: map commits to review requests based on commit ID (bug 1245589); r?dminor

https://reviewboard.mozilla.org/r/33459/#review30589
Summary: Map commits to review requested based on MozReview-Commit-ID → Map commits to review requests based on MozReview-Commit-ID
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Product: Developer Services → MozReview
You need to log in before you can comment on or make changes to this bug.