Closed Bug 1245608 Opened 8 years ago Closed 8 years ago

implement and use new tour slideshow frame instead of old FTU

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Iteration:
47.2 - Feb 22

People

(Reporter: dmosedale, Assigned: dmosedale)

References

Details

(Whiteboard: [btpp-fix-now])

User Story

As a link-generator user, when I start for the first time, or when I select "Tour" from the gear menu, a 4 page slideshow with dummy content should open.

- When the user presses "See how it works" on the FTU panel or the tour menu item
   * switch hello button to persistent hover visual
   * close panel (maybe first?)
   * render a dummy browser in the center of the display:
     * contains simple react component (from web or perhaps chrome jar), containing X close widget 
     * content shows behind slideshow   
     * When the user switches tabs the slideshow stays where it is
- When the user clicks the hello button, nothing happens
- When the user presses the close widget
   * slideshow disappears
   * hello button reverts to normal state

Tech checklist:
* replace MozLoopService.openGettingStartedTour with code that dynamically adds the slideshow frame
* decide on dummy web page content location and get it running and packaged
* figure out how to implement (x) widget for leaving (ie communicate button removal to chrome)
  * can we catch window.close for that?
  * implement teardown code that removes frame
* implement hover state changes
* ensure user story criteria satisfied

Attachments

(1 file, 1 obsolete file)

Link to Github pull-request: https://github.com/Standard8/loop/pull/1
40 bytes, text/x-github-pull-request
Details | Review 
      No description provided.
User Story: (updated)
Summary: implement and use new tour slideshow instead of old FTU → implement and use new tour slideshow frame instead of old FTU
Rank: 19
Whiteboard: [triage]
https://github.com/mikedeboer/loop/commit/45d3299328516bc18a21f77c508807f4f27ed612 is a hint about where to look for hooking up window.close properly.
User Story: (updated)
WIP PR: https://github.com/dmose/loop/pull/2.  Still sorting out hooking the slideshow to close.
Attached file Link to github commit in pull request (obsolete) — 
Here's a single commit on a feature branch.  This commit is ready for review, I think.  It's not the bestest code over, but it's what we need given current deadlines, I think.

If whoever reviews it wants to add commits fixing concerns, I won't object.  But since you're all busy, no worries if not.  I should have time Thursday to do a reasonable amount, and it make sense to spin some review comments off to a high prioirity bug that shows up next on the list.
Attachment #8718216 - Flags: review?(standard8)
Attachment #8718216 - Flags: review?(mdeboer)
Attachment #8718216 - Flags: review?(edilee)
Hmmm, bugzilla didn't like my handcrafted single-commit review.  So here's the link:

https://github.com/mozilla/loop/commit/90f3aa7602005180e9fb8b9909c5b471e5b2da27
I'm expecting that it'll make sense to do the ui-review over Vidyo or F2F on Thursday, and I think habber is even in SF, though we might need Sevaan or Pau's review too?  The exciting part is that we need to land this and other critical slideshow bugs by end of day Thursday.
Flags: needinfo?(sfranks)
Flags: needinfo?(b.pmm)
Holly is cool to sign-off. We want to see it in action too, though, of course.
Flags: needinfo?(sfranks)
Flags: needinfo?(b.pmm)
r=Standard8 on the PR for the latest code, once the comments & mochitests are addressed.
Attachment #8718216 - Flags: review?(standard8)
Attachment #8718216 - Flags: review?(mdeboer)
Attachment #8718216 - Flags: review?(edilee)

        Attachment #8718216 -
        Attachment is obsolete: true

        Attachment #8718641 -
        Flags: ui-review?(hhabstritt.bugzilla)

    
    

    
  
Review was conducted remotely, over vidyo. Further bugs may be discovered once we are able to click through it ourselves. 

This will work for our v1 launch. See bug 1245666 for comments that relate to visual design and interaction within slides. See below for items we’ve identified to update for the next release (date TBD).

-----

- Mark tour as seen when tour opens. Currently tour is marked as seen when user closes container at any point. This change will solve bug when user opens additional window and and is allowed to open tour again from Hello panel. As a result, this will not allow multiple tours being shown in multiple windows.

    
    

    
  
https://github.com/mozilla/loop/commit/285e1000877a408d17bae296dbf2cf85b031cf27

Dan, can you check the open flags/comments and close once done?
Iteration: --- → 47.2 - Feb 22
Flags: needinfo?(dmose)

    
    

    
  
I raised the following bugs to follow-up on polish for the FTU following comments from Holly and Sevaan: 
- FTU hover states: bug 1251266
- FTU pagination: bug 1251270
- FTU keyword navigable: bug 1251273
- FTU last slide clearer exit: bug 1251277

    
    

    
  
Looks like RT covered the follow-ups, marking as closed as this landed a while ago.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(dmose)
Resolution: --- → FIXED

    
    

    
  
Comment on attachment 8718641 [details] [review]
Link to Github pull-request: https://github.com/Standard8/loop/pull/1

I believe the ui-review here is no longer necessary. Dropping flag.

        Attachment #8718641 -
        Flags: ui-review?(hhabstritt.bugzilla)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: