Closed Bug 1245684 Opened 7 years ago Closed 7 years ago

Download bootstrap files as archive instead of separate files

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(firefox47 fixed)

RESOLVED FIXED
mozilla47
Tracking Status
firefox47 --- fixed

People

(Reporter: gps, Assigned: gps)

Details

Attachments

(1 file)

Currently, bootstrap.py in standalone mode downloads each .py file separately. Mercurial's HTTP server supports obtaining archives of sub-directories. Let's switch the download mechanism to download archives so the process is faster.
This will perform a single HTTP request that completes in <1s. Contrast
with before when we performed multiple HTTP requests and the process
took several seconds.

Review commit: https://reviewboard.mozilla.org/r/33511/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/33511/
Attachment #8715551 - Flags: review?(mshal)
Attachment #8715551 - Flags: review?(mshal)
Comment on attachment 8715551 [details]
MozReview Request: Bug 1245684 - Download bootstrap files via a zip archive; r?mshal

https://reviewboard.mozilla.org/r/33511/#review30467

::: python/mozboot/bin/bootstrap.py:33
(Diff revision 1)
>  REPOSITORY_PATH_PREFIX = 'python/mozboot'

This is unused (but see below)

::: python/mozboot/bin/bootstrap.py
(Diff revision 1)
> -REPOSITORY_PATHS = [

Previously there was a fixed list of files to download, but now it is pulling in an extra couple files:

mozboot/mach_commands.py
bin/bootstrap.py
README.rst
setup.py

I'm not sure if this will cause a problem (maybe bin/bootstrap.py would?), but just a heads up in case it might. If not, feel free to ignore. It's definitely much faster this way!

::: python/mozboot/bin/bootstrap.py:63
(Diff revision 1)
> +            offset = f.filename.find('python/mozboot/') + len('python/mozboot/')

Maybe use REPOSITORY_PATH_PREFIX here? (After adding the trailing '/')
Comment on attachment 8715551 [details]
MozReview Request: Bug 1245684 - Download bootstrap files via a zip archive; r?mshal

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/33511/diff/1-2/
Attachment #8715551 - Flags: review?(mshal)
Attachment #8715551 - Flags: review?(mshal) → review+
Comment on attachment 8715551 [details]
MozReview Request: Bug 1245684 - Download bootstrap files via a zip archive; r?mshal

https://reviewboard.mozilla.org/r/33511/#review30877
https://hg.mozilla.org/mozilla-central/rev/e225ff82eace
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.