Closed Bug 1245685 Opened 8 years ago Closed 8 years ago

Intermittent browser_referrer_simple_click.js,browser_subdialogs.js,browser_views_liveupdate.js,browser_vimemacs.js,test_bug458091.html,browser_inlinesettings.js | application crashed [@ JSScript::maybeForwardedScriptSource()]

Categories

(Core :: JavaScript Engine, defect, P3)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1302914

People

(Reporter: KWierso, Assigned: fitzgen)

References

Details

(Keywords: crash, intermittent-failure)

Crash Data

Severity: normal → critical
Crash Signature: [@ JSScript::maybeForwardedScriptSource()]
Component: General → JavaScript Engine
Keywords: crash
Product: Firefox → Core
Jan, can you help find an owner to investigate this? Thanks!
Flags: needinfo?(jdemooij)
Summary: Intermittent browser_referrer_simple_click.js | application crashed [@ JSScript::maybeForwardedScriptSource()] → Intermittent browser_referrer_simple_click.js,browser_subdialogs.js,browser_vimemacs.js,test_bug458091.html | application crashed [@ JSScript::maybeForwardedScriptSource()]
We're calling JS_GetScriptFilename from the browser's BackgroundHangManager thread. JS_GetScriptFilename has the following comment:

    // This is called from ThreadStackHelper which can be called from another
    // thread or inside a signal hander, so we need to be careful in case a
    // copmacting GC is currently moving things around.
    return script->maybeForwardedFilename();

I looked at one of the reports, and the rax register contains 0xbad0bad1. That's RelocationOverlay::Relocated, so I guess this is not playing well with the GC for some reason.
Flags: needinfo?(jdemooij) → needinfo?(jcoppeard)
The forwarding logic compares one of the object's fields with RelocationOverlay::Relocated, so it's not that surprising to see it in a register.  I checked and none of the other threads are doing anything GC related.

This might be an issue with script source lifetime.  fitzgen, mind taking a look?
Flags: needinfo?(jcoppeard) → needinfo?(nfitzgerald)
Yeah, I can take a look in the next couple days.
Assignee: nobody → nfitzgerald
Status: NEW → ASSIGNED
Flags: needinfo?(nfitzgerald)
https://treeherder.mozilla.org/logviewer.html#?job_id=23921227&repo=mozilla-inbound
Summary: Intermittent browser_referrer_simple_click.js,browser_subdialogs.js,browser_vimemacs.js,test_bug458091.html | application crashed [@ JSScript::maybeForwardedScriptSource()] → Intermittent browser_referrer_simple_click.js,browser_subdialogs.js,browser_vimemacs.js,test_bug458091.html,browser_inlinesettings.js | application crashed [@ JSScript::maybeForwardedScriptSource()]
Summary: Intermittent browser_referrer_simple_click.js,browser_subdialogs.js,browser_vimemacs.js,test_bug458091.html,browser_inlinesettings.js | application crashed [@ JSScript::maybeForwardedScriptSource()] → Intermittent browser_referrer_simple_click.js,browser_subdialogs.js,browser_views_liveupdate.js,browser_vimemacs.js,test_bug458091.html,browser_inlinesettings.js | application crashed [@ JSScript::maybeForwardedScriptSource()]
Bulk assigning P3 to all open intermittent bugs without a priority set in Firefox components per bug 1298978.
Priority: -- → P3
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.