Closed
Bug 1245723
Opened 8 years ago
Closed 8 years ago
Make a bunch of toolkit browser-chrome tests e10s compatible
Categories
(Toolkit :: General, defect)
Toolkit
General
Tracking
()
RESOLVED
FIXED
mozilla47
People
(Reporter: mrbkap, Assigned: mrbkap)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
6.52 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
7.13 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
16.19 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
6.28 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
6.38 KB,
patch
|
Felipe
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8715600 -
Flags: review?(felipc)
Assignee | ||
Comment 2•8 years ago
|
||
Attachment #8715601 -
Flags: review?(felipc)
Assignee | ||
Comment 3•8 years ago
|
||
browser_bug471404.js had DOS line endings and an absolutely bizarre control flow. This is much better. The others were easier to convert (though I didn't bother using all of the new helpers).
Attachment #8715603 -
Flags: review?(felipc)
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8715600 [details] [diff] [review] Make the satchel browser-chrome test e10s compatible. The original version of this test appeared to have a bug: it asserted that there shouldn't be any FormHistory values at all (even in non-private mode), but that makes no sense. The code bore this out, I think, because it raced the database query with the insertion of the value in form history. In this version, I fixed the race so that in private mode, we're asserting that we never add to form history (according to the parent) in PB mode and that we do in non-PB mode. Let me know if I should go back to the old, racy, way (though someone would have to explain why that's preferable).
Updated•8 years ago
|
Attachment #8715600 -
Flags: review?(felipc) → review+
Updated•8 years ago
|
Attachment #8715601 -
Flags: review?(felipc) → review+
Comment 5•8 years ago
|
||
Comment on attachment 8715601 [details] [diff] [review] Make browser_bug680727 e10s compatible. Review of attachment 8715601 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/components/places/tests/browser/browser_bug680727.js @@ +22,5 @@ > + resolve(); > + }); > + }); > + }); > +} I wonder if we should transform this into a helper like: {ContentTask|BrowserTestUtils}.waitOnContentEvent(browser, "DOMContentLoaded")
Updated•8 years ago
|
Attachment #8715603 -
Flags: review?(felipc) → review+
Updated•8 years ago
|
Attachment #8716518 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 7•8 years ago
|
||
The re-enabled tests in browser/../social now pass (see also bug 1150147, comment 4).
Attachment #8717168 -
Flags: review?(felipc)
Updated•8 years ago
|
Attachment #8717168 -
Flags: review?(felipc) → review+
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ec570b146713a586b97e8dba1be53c7ba8f2a3b7 Bug 1245723 - Make the satchel browser-chrome test e10s compatible. r=felipe https://hg.mozilla.org/integration/mozilla-inbound/rev/4fb9f0cf852d67604b2ea47f34704b1b269eac31 Bug 1245723 - Make browser_bug680727 e10s compatible. r=felipe https://hg.mozilla.org/integration/mozilla-inbound/rev/cf3afc950bc88c5ce23cab31bcf61d98da0029f5 Bug 1245723 - Make crashreporter browser-chrome tests e10s compatible. r=felipe https://hg.mozilla.org/integration/mozilla-inbound/rev/158b793ccada3a75848dafc4939c86cc4e87f087 Bug 1245723 - Fix browser_frame_elements and re-enable now-passing tests. r=felipe
Assignee | ||
Comment 9•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/db76a38f2eb8aec3a377af68da7ae53828ce4cfc Bug 1245723 - Fix typo. r=typo
Comment 10•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ec570b146713 https://hg.mozilla.org/mozilla-central/rev/4fb9f0cf852d https://hg.mozilla.org/mozilla-central/rev/cf3afc950bc8 https://hg.mozilla.org/mozilla-central/rev/158b793ccada https://hg.mozilla.org/mozilla-central/rev/db76a38f2eb8
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Blocks: 1244221
I tried to uplift these to aurora to get e10s greened up, but hit conflicts. Could we get rebased patches if these would be useful on aurora?
You need to log in
before you can comment on or make changes to this bug.
Description
•