1245723 - Make a bunch of toolkit browser-chrome tests e10s compatible

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Comment 1

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Make the satchel browser-chrome test e10s compatible.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Make browser_bug680727 e10s compatible.

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Make crashreporter browser-chrome tests e10s compatible.

browser_bug471404.js had DOS line endings and an absolutely bizarre control flow. This is much better. The others were easier to convert (though I didn't bother using all of the new helpers).

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8715600 [details] [diff] [review]
Make the satchel browser-chrome test e10s compatible.

The original version of this test appeared to have a bug: it asserted that there shouldn't be any FormHistory values at all (even in non-private mode), but that makes no sense. The code bore this out, I think, because it raced the database query with the insertion of the value in form history. In this version, I fixed the race so that in private mode, we're asserting that we never add to form history (according to the parent) in PB mode and that we do in non-PB mode. Let me know if I should go back to the old, racy, way (though someone would have to explain why that's preferable).

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8715601 [details] [diff] [review]
Make browser_bug680727 e10s compatible.

Review of attachment 8715601 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/components/places/tests/browser/browser_bug680727.js
@@ +22,5 @@
> +        resolve();
> +      });
> +    });
> +  });
> +}

I wonder if we should transform this into a helper like:

{ContentTask|BrowserTestUtils}.waitOnContentEvent(browser, "DOMContentLoaded")

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: With that

Here's an interdiff.

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: More fixes

The re-enabled tests in browser/../social now pass (see also bug 1150147, comment 4).

Comment 8

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ec570b146713a586b97e8dba1be53c7ba8f2a3b7
Bug 1245723 - Make the satchel browser-chrome test e10s compatible. r=felipe

https://hg.mozilla.org/integration/mozilla-inbound/rev/4fb9f0cf852d67604b2ea47f34704b1b269eac31
Bug 1245723 - Make browser_bug680727 e10s compatible. r=felipe

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf3afc950bc88c5ce23cab31bcf61d98da0029f5
Bug 1245723 - Make crashreporter browser-chrome tests e10s compatible. r=felipe

https://hg.mozilla.org/integration/mozilla-inbound/rev/158b793ccada3a75848dafc4939c86cc4e87f087
Bug 1245723 - Fix browser_frame_elements and re-enable now-passing tests. r=felipe

Comment 9

[Blake Kaplan (:mrbkap) (inactive)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/db76a38f2eb8aec3a377af68da7ae53828ce4cfc
Bug 1245723 - Fix typo. r=typo

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ec570b146713
https://hg.mozilla.org/mozilla-central/rev/4fb9f0cf852d
https://hg.mozilla.org/mozilla-central/rev/cf3afc950bc8
https://hg.mozilla.org/mozilla-central/rev/158b793ccada
https://hg.mozilla.org/mozilla-central/rev/db76a38f2eb8

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I tried to uplift these to aurora to get e10s greened up, but hit conflicts. Could we get rebased patches if these would be useful on aurora?