Closed Bug 1245725 Opened 8 years ago Closed 8 years ago

[funsize] Partial MAR file names should be configurable

Categories

(Release Engineering :: Release Automation: Other, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rail, Assigned: rail)

References

Details

Attachments

(4 files)

47 bytes, text/x-github-pull-request
jlund
: review+
Details | Review
42 bytes, text/x-github-pull-request
jlund
: review+
Details | Review
42 bytes, text/x-github-pull-request
jlund
: review+
Details | Review
48 bytes, text/x-github-pull-request
rail
: review+
Details | Review
ATM they use not that predictable file names (Firefox-$buildid1-$buildid2-...). It'd be great to use file names similar to what we have now. Since funsize generates more than 1 file, we'll have to use a bit longer file names, containing locale and platform.
Attached file Pass templates
Attachment #8715612 - Flags: review?(jlund)
Attached file funsize changes
This doesn't require immediate deployment, because release promotion uses :latest images.
Attachment #8715616 - Flags: review?(jlund)
Attachment #8715612 - Flags: review?(jlund) → review+
Comment on attachment 8715616 [details] [review]
funsize changes

looks good but one comment about template default filename differing from releasetasks passed env. should they be the same? I'll r+ if you convince me otherwise :)
Attachment #8715616 - Flags: review?(jlund) → review-
Comment on attachment 8715616 [details] [review]
funsize changes

see PR
Attachment #8715616 - Flags: review- → review+
Attachment #8715612 - Flags: checked-in+
Attachment #8715616 - Flags: checked-in+
Attached file fix bad quoting
Attachment #8716387 - Flags: review?(jlund)
Comment on attachment 8716387 [details] [review]
fix bad quoting

this has been merged. see PR
Attachment #8716387 - Flags: review?(jlund) → review+
Attachment #8716387 - Flags: checked-in+
Attached file use {{version}}
Attachment #8716942 - Flags: review?(bugspam.Callek)
Comment on attachment 8716942 [details] [review]
use {{version}}

r+ed in the PR
Attachment #8716942 - Flags: review?(bugspam.Callek)
Attachment #8716942 - Flags: review+
Attachment #8716942 - Flags: checked-in+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: