Closed Bug 1245727 Opened 5 years ago Closed 5 years ago

Detect GCC more reliably for -Werror

Categories

(NSS :: Test, defect)

defect
Not set
normal

Tracking

(firefox47 affected)

RESOLVED FIXED
Tracking Status
firefox47 --- affected

People

(Reporter: mt, Assigned: mt)

References

Details

Attachments

(2 files)

Attached patch werror.patchSplinter Review
The -Werror stuff is a little too broad, which causes build failures on some platforms.  This reduces the scope to all gcc-like compilers (those that support -Werror -Wall).

ekr, I'm looking for a relatively fast turnaround, feel free to punt to Kai if it's too late.  I'll add a patch with `diff -w` so that you can see how little has really changed.
Attachment #8715611 - Flags: review?(ekr)
Attached patch werror-w.patchSplinter Review
Whitespace ignored.
Assignee: nobody → martin.thomson
Adding Tim since this is relevant to the changes he is making for ChaCha20+Poly1305 (maybe Tim can review this instead).
Comment on attachment 8715613 [details] [diff] [review]
werror-w.patch

Review of attachment 8715613 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with fixes below

::: coreconf/Werror.mk
@@ +3,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +# This sets WARNING_CFLAGS for gcc-like compilers.
> +

Extra space

@@ +12,3 @@
>  
>  ifndef CC_NAME
> +  ifneq (1,$(CC_IS_GCC))

Per discussion with MT this is backwards
Attachment #8715613 - Flags: review+
https://hg.mozilla.org/projects/nss/rev/ac0410997982
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 3.23
Depends on: 1254406
Comment on attachment 8715611 [details] [diff] [review]
werror.patch

Review of attachment 8715611 [details] [diff] [review]:
-----------------------------------------------------------------

This ain't gonna happen.
Attachment #8715611 - Flags: review?(ekr)
You need to log in before you can comment on or make changes to this bug.