1245727 - Detect GCC more reliably for -Werror

Status: RESOLVED FIXED

(NSS :: Test, defect)

Description

[Martin Thomson [:mt:]]

Attachment: werror.patch

The -Werror stuff is a little too broad, which causes build failures on some platforms.  This reduces the scope to all gcc-like compilers (those that support -Werror -Wall).

ekr, I'm looking for a relatively fast turnaround, feel free to punt to Kai if it's too late.  I'll add a patch with `diff -w` so that you can see how little has really changed.

Comment 1

[Martin Thomson [:mt:]]

Attachment: werror-w.patch

Whitespace ignored.

Comment 2

[Martin Thomson [:mt:]]

Adding Tim since this is relevant to the changes he is making for ChaCha20+Poly1305 (maybe Tim can review this instead).

Comment 3

[Eric Rescorla (:ekr)]

Comment on attachment 8715613 [details] [diff] [review]
werror-w.patch

Review of attachment 8715613 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with fixes below

::: coreconf/Werror.mk
@@ +3,5 @@
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +# This sets WARNING_CFLAGS for gcc-like compilers.
> +

Extra space

@@ +12,3 @@
>  
>  ifndef CC_NAME
> +  ifneq (1,$(CC_IS_GCC))

Per discussion with MT this is backwards

Comment 4

[Martin Thomson [:mt:]]

https://hg.mozilla.org/projects/nss/rev/ac0410997982

Comment 5

[Martin Thomson [:mt:]]

Comment on attachment 8715611 [details] [diff] [review]
werror.patch

Review of attachment 8715611 [details] [diff] [review]:
-----------------------------------------------------------------

This ain't gonna happen.