1245767 - Allow combining different gczeal/zealMode values

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Jan de Mooij [:jandem]]

Currently zealMode is a single value that can be set with gczeal(x). Looking at our zeal values, it might be interesting to combine some of those modes.

I think we can do that with minimal changes to tests and code if we use a bit for each mode, for instance gczeal(x) would no longer do |zealMode = x| but |zealMode ^= (1 << x)|.

gczeal(0) is a special case: it'd simply clear all bits.

Comment 1

[Jan de Mooij [:jandem]]

I'll try to prototype this quickly to see if it works.

Comment 2

[Jan de Mooij [:jandem]]

Attachment: Patch

This adds an enum class for the zeal values and GCRuntime::hasZealMode to check if a zeal mode is active. Passes all shell tests.

Comment 3

[Terrence Cole [:terrence]]

Comment on attachment 8715720 [details] [diff] [review]
Patch

Review of attachment 8715720 [details] [diff] [review]:
-----------------------------------------------------------------

This is GREAT! I've been meaning to do something like this for ages.

The next step I'd like to see is to have setZeal take a string instead of an integer so that people will stop asking what mode does what.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e2fa804302c9

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9756e7631ad9

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a25fd5f06b68

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/e2fa804302c9
https://hg.mozilla.org/mozilla-central/rev/9756e7631ad9
https://hg.mozilla.org/mozilla-central/rev/a25fd5f06b68