shared-head should call Services.prefs.clearUserPref("devtools.toolbox.selectedTool"); on cleanup

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
3 years ago
6 months ago

People

(Reporter: pbro, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

3 years ago
While fixing bug 1245420, I ended up having various problems related to tests assuming that a given panel would be selected, and that tests would run in a certain order.
Changing these assumptions make some tests fail, and it's usually hard to investigate.

A lot of tests use helpers from devtools\client\framework\test\shared-head.js and this file also registers a cleanup function that clears up a few prefs already:

  Services.prefs.clearUserPref("devtools.dump.emit");
  Services.prefs.clearUserPref("devtools.toolbox.host");
  Services.prefs.clearUserPref("devtools.toolbox.previousHost");

We should also clear this:

  Services.prefs.clearUserPref("devtools.toolbox.selectedTool");

I'm moving this to a separate bug because this impacts many tests and will most probably cause weird failures for tests that assumed a different tool would be selected.
Good idea

Updated

6 months ago
Product: Firefox → DevTools
(Reporter)

Comment 2

6 months ago
No changes after 2 years. This has probably lost its relevance and is out of context. Not actionable at this stage.
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.