Closed Bug 1245828 Opened 4 years ago Closed 4 years ago

Port Bug 1242641 to comm-*: GTK+3 still not working for buildbot builds on beta

Categories

(MailNews Core :: Build Config, defect)

Unspecified
Linux
defect
Not set

Tracking

(thunderbird47 fixed)

RESOLVED FIXED
Thunderbird 47.0
Tracking Status
thunderbird47 --- fixed

People

(Reporter: Callek, Assigned: Callek)

References

Details

Attachments

(2 files)

This is a port of 1242641, tracked in its own bug.

Once 1242641 lands on m-c and m-a we'll need comm-* equivelant pushes due to the way Thunderbird (and SeaMonkey's) build systems are.

That said, this patch is also going to break SeaMonkey (I'm not sure if we have newer tooltool on our systems, and I know we don't yet run tooltool inside mock for SeaMonkey)

I'm defaulting to break-seamonkey not thunderbird with this patch though.

n-i to ewong for seamonkey so we can fix this on our end in a seperate bug :-)
Attachment #8715803 - Flags: review?(aleth)
Flags: needinfo?(ewong)
Comment on attachment 8715803 [details] [diff] [review]
[comm-central] gtk3 port

Review of attachment 8715803 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.
Attachment #8715803 - Flags: review?(aleth) → review+
(In reply to Justin Wood (:Callek) from comment #0)
> I'm defaulting to break-seamonkey not thunderbird with this patch though.

OK, in that case I will land this.
https://hg.mozilla.org/comm-central/rev/030d69914e5828d2e84cc7d34e3e84e84d1476e8
Bug 1245828 - Port Bug 1242641 to comm-*: GTK+3 still not working for buildbot builds on beta. r=aleth a=me CLOSED TREE
https://hg.mozilla.org/releases/comm-aurora/rev/f03ba211a18517b848aee69f184dedd2942c1e23
Bug 1245828 - Port Bug 1242641 to comm-*: GTK+3 still not working for buildbot builds on beta. r=aleth a=aleth
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
ewong: Note comm-beta is still missing the suite part of this patch.
Note that we are once again disabling GTK3 for Firefox 45, see bug 1245476, that may affect comm-beta as well.
Backed out of c-c.
(In reply to aleth [:aleth] from comment #7)
> Backed out of c-c.

Does this mean REOPENED?

-- GTK3 is of course Linux-only (at least among Tier1 platforms).
OS: Unspecified → Linux
(In reply to Tony Mechelynck [:tonymec] from comment #8)
> (In reply to aleth [:aleth] from comment #7)
> > Backed out of c-c.
> 
> Does this mean REOPENED?

Yes, sorry.
 
> -- GTK3 is of course Linux-only (at least among Tier1 platforms).

That's true, but c-* builds fail on all platforms when the tooltool-manifests and certain mozconfigs don't match the m-* versions, due to a 'dumb' check-sync-dirs build step that enforces this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Sorry, I backed this out from Aurora (TB46) since I was seeing too many oranges:
https://hg.mozilla.org/releases/comm-aurora/rev/ca971eed8b49
https://hg.mozilla.org/comm-central/rev/b44ba41b58d64175a00200850d0ce597e4472716
Bug 1245828 - Port Bug 1242641 to comm-*: GTK+3 still not working for buildbot builds on beta. rs=bustage-fix
Assignee: bugspam.Callek → aleth
Status: REOPENED → ASSIGNED
Assignee: aleth → bugspam.Callek
https://hg.mozilla.org/releases/comm-aurora/rev/e11d742cc6695e4570a01c0718edb63d9bc7993e
Bug 1245828 - Port Bug 1242641 to comm-*: GTK+3 still not working for buildbot builds on beta. rs=bustage-fix a=aleth
Status: ASSIGNED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Flags: needinfo?(ewong)
You need to log in before you can comment on or make changes to this bug.