Closed
Bug 1245828
Opened 8 years ago
Closed 8 years ago
Port Bug 1242641 to comm-*: GTK+3 still not working for buildbot builds on beta
Categories
(MailNews Core :: Build Config, defect)
Tracking
(thunderbird47 fixed)
RESOLVED
FIXED
Thunderbird 47.0
Tracking | Status | |
---|---|---|
thunderbird47 | --- | fixed |
People
(Reporter: Callek, Assigned: Callek)
References
Details
Attachments
(2 files)
3.20 KB,
patch
|
aleth
:
review+
|
Details | Diff | Splinter Review |
5.46 KB,
patch
|
Details | Diff | Splinter Review |
This is a port of 1242641, tracked in its own bug. Once 1242641 lands on m-c and m-a we'll need comm-* equivelant pushes due to the way Thunderbird (and SeaMonkey's) build systems are. That said, this patch is also going to break SeaMonkey (I'm not sure if we have newer tooltool on our systems, and I know we don't yet run tooltool inside mock for SeaMonkey) I'm defaulting to break-seamonkey not thunderbird with this patch though. n-i to ewong for seamonkey so we can fix this on our end in a seperate bug :-)
Attachment #8715803 -
Flags: review?(aleth)
Flags: needinfo?(ewong)
Comment 1•8 years ago
|
||
Comment on attachment 8715803 [details] [diff] [review] [comm-central] gtk3 port Review of attachment 8715803 [details] [diff] [review]: ----------------------------------------------------------------- Thanks.
Attachment #8715803 -
Flags: review?(aleth) → review+
Comment 2•8 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #0) > I'm defaulting to break-seamonkey not thunderbird with this patch though. OK, in that case I will land this.
Comment 3•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/030d69914e5828d2e84cc7d34e3e84e84d1476e8 Bug 1245828 - Port Bug 1242641 to comm-*: GTK+3 still not working for buildbot builds on beta. r=aleth a=me CLOSED TREE
Comment 4•8 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/f03ba211a18517b848aee69f184dedd2942c1e23 Bug 1245828 - Port Bug 1242641 to comm-*: GTK+3 still not working for buildbot builds on beta. r=aleth a=aleth
Updated•8 years ago
|
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 47.0
Comment 5•8 years ago
|
||
ewong: Note comm-beta is still missing the suite part of this patch.
Comment 6•8 years ago
|
||
Note that we are once again disabling GTK3 for Firefox 45, see bug 1245476, that may affect comm-beta as well.
Comment 7•8 years ago
|
||
Backed out of c-c.
Comment 8•8 years ago
|
||
(In reply to aleth [:aleth] from comment #7) > Backed out of c-c. Does this mean REOPENED? -- GTK3 is of course Linux-only (at least among Tier1 platforms).
OS: Unspecified → Linux
Comment 9•8 years ago
|
||
(In reply to Tony Mechelynck [:tonymec] from comment #8) > (In reply to aleth [:aleth] from comment #7) > > Backed out of c-c. > > Does this mean REOPENED? Yes, sorry. > -- GTK3 is of course Linux-only (at least among Tier1 platforms). That's true, but c-* builds fail on all platforms when the tooltool-manifests and certain mozconfigs don't match the m-* versions, due to a 'dumb' check-sync-dirs build step that enforces this.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 10•8 years ago
|
||
Sorry, I backed this out from Aurora (TB46) since I was seeing too many oranges: https://hg.mozilla.org/releases/comm-aurora/rev/ca971eed8b49
status-thunderbird46:
--- → affected
status-thunderbird47:
--- → affected
Comment 11•8 years ago
|
||
For completeness: C-C backout from comment #7: https://hg.mozilla.org/comm-central/rev/59e860b594d6
Comment 12•8 years ago
|
||
https://hg.mozilla.org/comm-central/rev/b44ba41b58d64175a00200850d0ce597e4472716 Bug 1245828 - Port Bug 1242641 to comm-*: GTK+3 still not working for buildbot builds on beta. rs=bustage-fix
Comment 13•8 years ago
|
||
Unbitrotted version, checked into c-c.
Updated•8 years ago
|
Assignee: bugspam.Callek → aleth
Status: REOPENED → ASSIGNED
Updated•8 years ago
|
Assignee: aleth → bugspam.Callek
Comment 14•8 years ago
|
||
https://hg.mozilla.org/releases/comm-aurora/rev/e11d742cc6695e4570a01c0718edb63d9bc7993e Bug 1245828 - Port Bug 1242641 to comm-*: GTK+3 still not working for buildbot builds on beta. rs=bustage-fix a=aleth
Updated•8 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Flags: needinfo?(ewong)
Updated•8 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•