Closed
Bug 1245845
Opened 9 years ago
Closed 9 years ago
Preserve the FillRule of Paths passed to gfxContext::SetPath
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla47
Tracking | Status | |
---|---|---|
firefox47 | --- | fixed |
People
(Reporter: jwatt, Assigned: jwatt)
References
Details
Attachments
(2 files, 1 obsolete file)
8.06 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
916 bytes,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
Bug 1229662 (http://hg.mozilla.org/mozilla-central/rev/66b2ca5d7bc2) broke clipping is some tests that I'm trying to land by causing the FillRule of Paths passed to gfxContext::SetPath to be lost sometimes. The issues are in gfxContext::EnsurePath/EnsurePathBuilder since they now copy paths without copying the FillRule.
![]() |
Assignee | |
Comment 1•9 years ago
|
||
Attachment #8715825 -
Flags: review?(bas)
Comment 2•9 years ago
|
||
Would it not be safer if TransformedCopyToBuilder and CopyToBuilder did not have a default fillRule argument?
![]() |
Assignee | |
Comment 3•9 years ago
|
||
I think that would be better, yes.
Bas, what would you think of me overloading these methods with inline versions that don't take an argument and just pass on the Path's FillRule to the current virtual methods?
![]() |
Assignee | |
Comment 4•9 years ago
|
||
Attachment #8716693 -
Flags: review?(bas)
![]() |
Assignee | |
Comment 5•9 years ago
|
||
Attachment #8716695 -
Flags: review?(bas)
![]() |
Assignee | |
Updated•9 years ago
|
Attachment #8715825 -
Attachment is obsolete: true
Attachment #8715825 -
Flags: review?(bas)
![]() |
Assignee | |
Comment 6•9 years ago
|
||
Try seems happy enough https://treeherder.mozilla.org/#/jobs?repo=try&revision=c41e1f835027
Updated•9 years ago
|
Attachment #8716693 -
Flags: review?(bas) → review+
Updated•9 years ago
|
Attachment #8716695 -
Flags: review?(bas) → review+
Comment 8•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5df2781a3b0c
https://hg.mozilla.org/mozilla-central/rev/37d340a97af0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in
before you can comment on or make changes to this bug.
Description
•