'Open and Fill' login does not present the newly opened tab when accessed from the private tab drawer

RESOLVED FIXED in 2.0

Status

()

Firefox for iOS
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aaronmt, Assigned: sleroux)

Tracking

({reproducible})

unspecified
All
iOS
reproducible

Firefox Tracking Flags

(fxios2.0+)

Details

(Reporter)

Description

2 years ago
Tabs > Private > Settings > Logins > *select a login* > 'Open & Fill'

Settings closes and the background 'regular' tab is opened in the background.

-----

Expected: Take me to the newly opened 'regular' tab

or

Expected: Open to fill in a new private tab (probably requires more work)
(Reporter)

Updated

2 years ago
Flags: needinfo?(sleroux)
Keywords: reproducible
(Assignee)

Updated

2 years ago
Assignee: nobody → sleroux
Status: NEW → ASSIGNED
Flags: needinfo?(sleroux)
(Assignee)

Comment 1

2 years ago
I've addressed this as part of https://bugzilla.mozilla.org/show_bug.cgi?id=1242479.

https://github.com/mozilla/firefox-ios/commit/356f74f861164ebe938dc3d7d369cc45527748b5

I've chosen to open a new private tab instead of going back and opening a normal tab for a couple of reasons:

1. If the user has the 'Close Private Tabs' switch ON, when we automatically switch to normal tabs from private mode the user will lose all their tabs when that probably wasn't their intention.

2. Additional refactoring would be required to get the animation timing right between switching from private -> normal then handling the open tab animation.
(Assignee)

Comment 2

2 years ago
master 696967ac51a8e049c3b10194e5db6b737f742bf7
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
tracking-fxios: ? → 2.0+
Resolution: --- → FIXED
Target Milestone: --- → 2.0
You need to log in before you can comment on or make changes to this bug.