1245893 - Please deploy loop standalone 0.3.0 to STAGE

Status: RESOLVED WONTFIX

(Cloud Services :: Operations: Deployment Requests - DEPRECATED, task)

Description

[Mark Banner (:standard8)]

------------------
RELEASE NOTES
------------------
https://github.com/mozilla/loop/blob/release/CHANGELOG.md

COMPARISONS
None due to new repo

TAGS
https://github.com/mozilla/loop/releases/tag/v0.3.0
https://github.com/mozilla/loop/commit/ffc7764be3f36d45d08a8db3aae5ffaaba6d8800

Notes for build:

As this is a new repo, here's the basic build steps.

  $ make install
  $ make build
  $ make dist

The standalone files are then all located in dist/standalone/. It'll need the config.js file placing in the top level alongside the index.html the same as we did with the loop-client repo.

Adding dependency on CSP bug as we want to push that to users with this release as well, i.e. reporting + live.

Comment 1

[Bob Micheletto [:bobm]]

Changing assignee to :jp.

Comment 2

[Bob Micheletto [:bobm]]

Ran into the following traceback during build:
python bin/generateChromeManifest.py --input-file=add-on/jar.mn --output-file=built/add-on/chrome.manifest --src=locale
Using l10n tree from locale
Traceback (most recent call last):
  File "bin/generateChromeManifest.py", line 82, in <module>
    main(args.src, args.input_file, args.output_file)
  File "bin/generateChromeManifest.py", line 28, in main
    jar_mn = input_file.read()
  File "/usr/lib64/python2.6/io.py", line 1767, in read
    decoder.decode(self.buffer.read(), final=True))
  File "/usr/lib64/python2.6/io.py", line 1319, in decode
    output = self.decoder.decode(input, final=final)
  File "/builddir/build/BUILD/loop-client-svcops-20160209232734/lib64/python2.6/encodings/ascii.py", line 26, in decode
    return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 3521: ordinal not in range(128)
make: *** [built/add-on/chrome.manifest] Error 1
error: Bad exit status from /var/tmp/rpm-tmp.0h9f1z (%build)
RPM build errors:
    Bad exit status from /var/tmp/rpm-tmp.0h9f1z (%build)
Child return code was: 1
EXCEPTION: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps  /builddir/build/SPECS/loop-client.spec 
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/mockbuild/trace_decorator.py", line 84, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.6/site-packages/mockbuild/util.py", line 504, in do
    raise exception.Error("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # bash --login -c /usr/bin/rpmbuild -bb --target x86_64 --nodeps  /builddir/build/SPECS/loop-client.spec 
LEAVE do --> EXCEPTION RAISED

Comment 3

[Mark Banner (:standard8)]

Can you try setting LANG=en-US.utf8 in the environment. I think that should fix it.

Comment 4

[Bob Micheletto [:bobm]]

:jp give that a try.

Comment 5

[Daniel Maher [:phrawzty]]

(In reply to Mark Banner (:standard8) from comment #3)
> Can you try setting LANG=en-US.utf8 in the environment. I think that should
> fix it.

Unfortunately, this doesn't appear to solve the problem in our build environment. :(  Are we sure that Python 2.6 (or 2.x) uses the LANG environment variable to set the default encoding at runtime?  Consider this output from my laptop:


$ /usr/bin/env LANG="en_US.UTF-8" python -c 'import sys; import locale; print sys.getdefaultencoding(); print locale.getdefaultlocale()'
ascii
('en_CA', 'UTF-8')


Above we see that LANG affects neither defaultencoding nor defaultlocale.

Question: Might we solve this by explicitly setting defaultencoding in a site.py for this build?  Is there another (read: better? cleaner?) way to do this?

Comment 6

[Mark Banner (:standard8)]

All I know is that I had a similar issue with running from crontab on our dev server, and to fix that I did 

export LANG="en_US.UTF-8"

before running the script started the python process.

The dev server runs python 2.7.5.

I'm not against changing this in site.py, but I don't know if there's a better way, that's all I found.

Comment 7

[Ian Bicking (:ianbicking)]

Changing the default encoding can potentially affect a bunch of stuff.  I think if https://github.com/mozilla/loop/blob/master/bin/generateChromeManifest.py#L26 was just:
  input_file = io.open(input_file_name, "rb") # Note the b

then it probably will be fine.  Or io.open(input_file_name, "r", encoding="UTF-8")

The actual value that matters can be found with:
  python -c 'import locale; print locale.getpreferredencoding()'

I guess it's the default filesystem encoding... but apparently there's no standard way to set this value.

Comment 8

[Mark Banner (:standard8)]

We need to change the version. There's been more code, plus I've just found a regression on the standalone.

Daniel, can you confirm if Ian's suggestion worked or not? If it did, I can get it into the next release...

Comment 9

[Mark Banner (:standard8)]

I've included an attempted fix in the 1.1.3 release - bug 1248491.