1245901 - Telemetry for browser CPOW usage, now rejected

Status: RESOLVED FIXED

(Core :: DOM: Content Processes, defect)

Description

[Benjamin Smedberg]

Browser usage of CPOWs now fails. We should have telemetry to count these failures for the following reasons:

1) to make sure that when users have no addons, that we aren't seeing any CPOW rejections/failures
2) to correlate failures with addons installed to see if particular addons are triggering failures

mconley, do you know where I would add this?

Comment 1

[Mike Conley (:mconley) (:⚙️)]

I believe right around here:

https://dxr.mozilla.org/mozilla-central/rev/584870f1cbc5d060a57e147ce249f736956e2b62/js/ipc/JavaScriptParent.cpp#77

Comment 2

[Benjamin Smedberg]

Attachment: MozReview Request: Bug 1245901 - Measure counts of browser CPOW usage which is now rejected, r?billm

Review commit: https://reviewboard.mozilla.org/r/35125/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/35125/

Comment 3

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8719804 [details]
MozReview Request: Bug 1245901 - Measure counts of browser CPOW usage which is now rejected, r?billm

https://reviewboard.mozilla.org/r/35125/#review32211

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c7f7934d62cc

Comment 5

[Benjamin Smedberg]

Comment on attachment 8719804 [details]
MozReview Request: Bug 1245901 - Measure counts of browser CPOW usage which is now rejected, r?billm

Approval Request Comment
[Feature/regressing bug #]: bug 1233497 turned off unsafe CPOWs for browser code. This is telemetry to see whether that disablement is affecting users. I'd like this on all channels where we're turning e10s on by default.
[User impact if declined]: Less confidence in e10s working correctly.
[Describe test coverage new/current, TreeHerder]: I did basic manual testing before landing
[Risks and why]: I judge this as very low risk
[String/UUID change made/needed]: None

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c7f7934d62cc

Comment 7

[Liz Henry (:lizzard)]

Marking 46 as affected since we plan to test staged rollout on 46 beta.

Comment 8

[Liz Henry (:lizzard)]

Comment on attachment 8719804 [details]
MozReview Request: Bug 1245901 - Measure counts of browser CPOW usage which is now rejected, r?billm

This should help give us useful data about e10s. Approved for uplift to aurora.