Closed Bug 1245912 Opened 4 years ago Closed 4 years ago

Land version 0.3.0 of the Loop system add-on in mozilla-central

Categories

(Hello (Loop) :: Client, defect, P1)

defect

Tracking

(firefox45 affected, firefox46 fixed, firefox47 fixed)

RESOLVED FIXED
mozilla47
Iteration:
47.1 - Feb 8
Tracking Status
firefox45 --- affected
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [btpp-fix-now])

Attachments

(1 file)

Since the last version that landed in mozilla-central we have:

- fixed l10n (landed in bug 1239828)
- Implemented the support work for e10s (bug 1154277)
- Various other fixes (see 0.2.0 & 0.3.0 list of changes in https://github.com/mozilla/loop/blob/v0.3.0/CHANGELOG.md).

The first two bugs have already landed. This bug is to bring up to date the rest of the changes in 0.3.0.
https://hg.mozilla.org/integration/fx-team/rev/e5257e46ac6a1d25ba13b884b7819e25a59af29d
Bug 1245912 - Update Loop system add-on to version 0.3.0. r=Standard8 for already reviewed code.
https://hg.mozilla.org/mozilla-central/rev/e5257e46ac6a
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
Attached patch 0.3.0 updateSplinter Review
Somehow forgot to add the patch when I first landed this.
Comment on attachment 8717500 [details] [diff] [review]
0.3.0 update

Needs to land in combination with bug 1239828, bug 1246592 and bug 1154277.

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello, go faster add-on.
[User impact if declined]: Won't be able to ship the next version of the Hello add-on
[Describe test coverage new/current, TreeHerder]: Landed in m-c. Code has tests
[Risks and why]: Low for this patch. This completes the 0.3.0 update of the Hello system add-on, alongside the previously mentioned bugs. This includes a set of Locaisation updates, plus a couple of minor bug fixes and gets the add-on in a shape where we can easily update it for 45 & future releases.
[String/UUID change made/needed]: None

I'm not requesting approval for beta just yet, until I verify the patch applies without bitrot, which I'll be doing once I've done the patches on bug 1239828.
Attachment #8717500 - Flags: approval-mozilla-aurora?
Comment on attachment 8717500 [details] [diff] [review]
0.3.0 update

Approval Request Comment

Please see previous comment, I've verified this applies to aurora/beta after the other approvals are landed.
Attachment #8717500 - Flags: approval-mozilla-beta?
Comment on attachment 8717500 [details] [diff] [review]
0.3.0 update

Even if I am not really happy to see such important change that late in the cycle, OK, let's take it. Should be in 45 beta 5.
Attachment #8717500 - Flags: approval-mozilla-beta?
Attachment #8717500 - Flags: approval-mozilla-beta+
Attachment #8717500 - Flags: approval-mozilla-aurora?
Attachment #8717500 - Flags: approval-mozilla-aurora+
has problems landing on aurora, merging browser/extensions/loop/chrome/content/shared/js/actions.js                                                                                                                                       
merging browser/extensions/loop/chrome/content/shared/js/otSdkDriver.js                                                                                                                                   
merging browser/extensions/loop/chrome/content/shared/test/otSdkDriver_test.js                                                                                                                            
merging browser/extensions/loop/install.rdf.in                                                                                                                                                            
warning: conflicts while merging browser/extensions/loop/bootstrap.js! (edit, then use 'hg resolve --mark')                                                                                               
warning: conflicts while merging browser/extensions/loop/install.rdf.in! (edit, then use 'hg resolve --mark')                                                                                             
abort: unresolved conflicts, can't continue                                                                 

Mark, could you take a look? thanks!
Flags: needinfo?(standard8)
Please see comment 4 - this needs landing in combination with the other bugs - bug 1239828, bug 1246592 and bug 1154277.
Flags: needinfo?(standard8)
Mark, this is a lot of patches for that late in the cycle. I would prefer to delay that to 46.
I don't see the point of rushing now. We are past beta 4, 45 is an esr release and I would like to avoid dealing with potential regressions of these patches.
WDYT?
Attachment #8717500 - Flags: approval-mozilla-beta?
Attachment #8717500 - Flags: approval-mozilla-beta+
Attachment #8717500 - Flags: approval-mozilla-aurora?
Attachment #8717500 - Flags: approval-mozilla-aurora+
(In reply to Sylvestre Ledru [:sylvestre] from comment #9)
> Mark, this is a lot of patches for that late in the cycle. I would prefer to
> delay that to 46.
> I don't see the point of rushing now. We are past beta 4, 45 is an esr
> release and I would like to avoid dealing with potential regressions of
> these patches.
> WDYT?

The work we're doing here is all vital parts of our Go faster effort. We've already got a meeting scheduled with you later today, so we can go through these as part of that discussion.
This patch represents a system add-on update, the kind of update we later plan to send to 45 GA users.  We'd like to get this into beta first to get wider testing and so the up-to-date version of the add-on is shipped to users with 45.  This process is where the discussion has led us for the initial phases of Go Faster.  (We do expect a final version later this week, but that should be confined to the add-on and perhaps small Telemetry changes.)

Hello should be turned off for ESR (as it was for the last ESR), for the last ESR release that was done with a pref.

The l10n-related patches are primarily to Loop/Hello itself, except for some small build file changes; these allow Hello translations to be correctly packed for localized versions.  (As part of the Go Faster plan we are not using the Firefox desktop localization system.)

The e10s-related SocialAPI changes are more substantive.  We are the only current consumer of the SocialAPI conversation window (only Facebook used this particular feature of SocialAPI in the past, and they disabled support over a year ago).  We will have to remove the SocialAPI dependency in the future to fully realize the benefit of Go Faster releases in the future, but for now we've added e10s support in-place.
Flags: needinfo?(sledru)
Comment on attachment 8717500 [details] [diff] [review]
0.3.0 update

More work to move Hello into a system addon. OK to uplift to aurora.
Attachment #8717500 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Clearing the ni as the discussion is happening in an email thread.
Flags: needinfo?(sledru)
Comment on attachment 8717500 [details] [diff] [review]
0.3.0 update

Should be in 45 beta 6.
Attachment #8717500 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(standard8)
backed out by request from sylvestre in https://treeherder.mozilla.org/#/jobs?repo=mozilla-beta&revision=8bf2c5452d44
Flags: needinfo?(standard8)
Flags: needinfo?(standard8)
You need to log in before you can comment on or make changes to this bug.